make useUser return null user data on error (restored original behaviour)

Author: tusharpandey13

src/client/hooks/use-user.test.tsx

@@ -3,9 +3,17 @@
  */
 
 import React from "react";
-import { afterEach, beforeEach, describe, expect, it, vi, type MockInstance } from "vitest";
 import { act, renderHook, waitFor } from "@testing-library/react";
 import * as swrModule from "swr";
+import {
+  afterEach,
+  beforeEach,
+  describe,
+  expect,
+  it,
+  vi,
+  type MockInstance
+} from "vitest";
 
 import type { User } from "../../types/index.js";
 import { useUser } from "./use-user.js";
@@ -137,7 +145,10 @@ describe.only("useUser Integration with SWR Cache", () => {
 
   // Explicitly type fetchSpy using MockInstance and the global fetch signature
   let fetchSpy: MockInstance<
-    (input: RequestInfo | URL, init?: RequestInit | undefined) => Promise<Response>
+    (
+      input: RequestInfo | URL,
+      init?: RequestInit | undefined
+    ) => Promise<Response>
   >;
 
   beforeEach(() => {
@@ -159,7 +170,9 @@ describe.only("useUser Integration with SWR Cache", () => {
     );
 
     const wrapper = ({ children }: { children: React.ReactNode }) => (
-      <swrModule.SWRConfig value={{ provider: () => new Map() }}>{children}</swrModule.SWRConfig>
+      <swrModule.SWRConfig value={{ provider: () => new Map() }}>
+        {children}
+      </swrModule.SWRConfig>
     );
 
     const { result } = renderHook(() => useUser(), { wrapper });
@@ -233,12 +246,12 @@ describe.only("useUser Integration with SWR Cache", () => {
       result.current.invalidate();
     });
 
-     // Wait for the hook to reflect the error state, user should still be the initial one before error
+    // Wait for the hook to reflect the error state, user should still be the initial one before error
     await waitFor(() => expect(result.current.error).not.toBeNull());
 
     // Assert error state - SWR catches the rejection from fetch itself.
     // Check for the message of the error we explicitly rejected with.
-    expect(result.current.user).toEqual(initialUser); // SWR might keep stale data upon rejection
+    expect(result.current.user).toBeNull(); // Expect null now, not stale data
     expect(result.current.error?.message).toBe(fetchError.message); // Correct assertion
     expect(result.current.isLoading).toBe(false);
 

src/client/hooks/use-user.ts

@@ -10,15 +10,15 @@ export function useUser() {
     (...args) =>
       fetch(...args).then((res) => {
         if (!res.ok) {
-          throw new Error(res.statusText || "Fetch error");
+          throw new Error("Unauthorized");
         }
         return res.json();
       })
   );
 
   if (error) {
     return {
-      user: data,
+      user: null,
       isLoading: false,
       error,
       invalidate: () => mutate()
@@ -35,9 +35,9 @@ export function useUser() {
   }
 
   return {
-    user: null,
+    user: data,
     isLoading,
-    error: null,
+    error,
     invalidate: () => mutate()
   };
 }