linting fixes

Author: tusharpandey13

src/server/auth-client.test.ts

@@ -394,7 +394,7 @@ ca/T0LLtgmbMmxSv/MmzIg==
       // When a route doesn't match, the handler returns a NextResponse.next() with status 200
       expect(response.status).toBe(200);
     });
-    
+
     it("should use the default value (true) for enableAccessTokenEndpoint when not explicitly provided", async () => {
       const secret = await generateSecret(32);
       const transactionStore = new TransactionStore({
@@ -4374,53 +4374,65 @@ ca/T0LLtgmbMmxSv/MmzIg==
       const authClient = await createAuthClient({
         signInReturnToPath: defaultReturnTo
       });
-      
+
       // Mock the transactionStore.save method to verify the saved state
-      const originalSave = authClient['transactionStore'].save;
-      authClient['transactionStore'].save = vi.fn(async (cookies, state) => {
+      const originalSave = authClient["transactionStore"].save;
+      authClient["transactionStore"].save = vi.fn(async (cookies, state) => {
         expect(state.returnTo).toBe(defaultReturnTo);
-        return originalSave.call(authClient['transactionStore'], cookies, state);
+        return originalSave.call(
+          authClient["transactionStore"],
+          cookies,
+          state
+        );
       });
 
       await authClient.startInteractiveLogin();
-      
-      expect(authClient['transactionStore'].save).toHaveBeenCalled();
+
+      expect(authClient["transactionStore"].save).toHaveBeenCalled();
     });
 
     it("should sanitize and use the provided returnTo parameter", async () => {
       const authClient = await createAuthClient();
       const returnTo = "/custom-return-path";
-      
+
       // Mock the transactionStore.save method to verify the saved state
-      const originalSave = authClient['transactionStore'].save;
-      authClient['transactionStore'].save = vi.fn(async (cookies, state) => {
+      const originalSave = authClient["transactionStore"].save;
+      authClient["transactionStore"].save = vi.fn(async (cookies, state) => {
         // The full URL is saved, not just the path
         expect(state.returnTo).toBe("https://example.com/custom-return-path");
-        return originalSave.call(authClient['transactionStore'], cookies, state);
+        return originalSave.call(
+          authClient["transactionStore"],
+          cookies,
+          state
+        );
       });
 
       await authClient.startInteractiveLogin({ returnTo });
-      
-      expect(authClient['transactionStore'].save).toHaveBeenCalled();
+
+      expect(authClient["transactionStore"].save).toHaveBeenCalled();
     });
 
     it("should reject unsafe returnTo URLs", async () => {
       const authClient = await createAuthClient({
         signInReturnToPath: "/safe-path"
       });
       const unsafeReturnTo = "https://malicious-site.com";
-      
+
       // Mock the transactionStore.save method to verify the saved state
-      const originalSave = authClient['transactionStore'].save;
-      authClient['transactionStore'].save = vi.fn(async (cookies, state) => {
+      const originalSave = authClient["transactionStore"].save;
+      authClient["transactionStore"].save = vi.fn(async (cookies, state) => {
         // Should use the default safe path instead of the malicious one
         expect(state.returnTo).toBe("/safe-path");
-        return originalSave.call(authClient['transactionStore'], cookies, state);
+        return originalSave.call(
+          authClient["transactionStore"],
+          cookies,
+          state
+        );
       });
 
       await authClient.startInteractiveLogin({ returnTo: unsafeReturnTo });
-      
-      expect(authClient['transactionStore'].save).toHaveBeenCalled();
+
+      expect(authClient["transactionStore"].save).toHaveBeenCalled();
     });
 
     it("should pass authorization parameters to the authorization URL", async () => {
@@ -4429,10 +4441,10 @@ ca/T0LLtgmbMmxSv/MmzIg==
         audience: "https://api.example.com",
         scope: "openid profile email custom_scope"
       };
-      
+
       // Spy on the authorizationUrl method to verify the passed params
-      const originalAuthorizationUrl = authClient['authorizationUrl'];
-      authClient['authorizationUrl'] = vi.fn(async (params) => {
+      const originalAuthorizationUrl = authClient["authorizationUrl"];
+      authClient["authorizationUrl"] = vi.fn(async (params) => {
         // Verify the audience is set correctly
         expect(params.get("audience")).toBe(authorizationParameters.audience);
         // Verify the scope is set correctly
@@ -4441,8 +4453,8 @@ ca/T0LLtgmbMmxSv/MmzIg==
       });
 
       await authClient.startInteractiveLogin({ authorizationParameters });
-      
-      expect(authClient['authorizationUrl']).toHaveBeenCalled();
+
+      expect(authClient["authorizationUrl"]).toHaveBeenCalled();
     });
 
     it("should handle pushed authorization requests (PAR) correctly", async () => {
@@ -4452,11 +4464,11 @@ ca/T0LLtgmbMmxSv/MmzIg==
           parRequestCalled = true;
         }
       });
-      
+
       const secret = await generateSecret(32);
       const transactionStore = new TransactionStore({ secret });
       const sessionStore = new StatelessSessionStore({ secret });
-      
+
       const authClient = new AuthClient({
         transactionStore,
         sessionStore,
@@ -4471,33 +4483,41 @@ ca/T0LLtgmbMmxSv/MmzIg==
         },
         fetch: mockFetch
       });
-      
+
       await authClient.startInteractiveLogin();
-      
+
       // Verify that PAR was used
       expect(parRequestCalled).toBe(true);
     });
-    
+
     it("should save the transaction state with correct values", async () => {
       const authClient = await createAuthClient();
       const returnTo = "/custom-path";
-      
+
       // Instead of mocking the oauth functions, we'll just check the structure of the transaction state
-      const originalSave = authClient['transactionStore'].save;
-      authClient['transactionStore'].save = vi.fn(async (cookies, transactionState) => {
-        expect(transactionState).toEqual(expect.objectContaining({
-          nonce: expect.any(String),
-          codeVerifier: expect.any(String),
-          responseType: "code",
-          state: expect.any(String),
-          returnTo: "https://example.com/custom-path"
-        }));
-        return originalSave.call(authClient['transactionStore'], cookies, transactionState);
-      });
+      const originalSave = authClient["transactionStore"].save;
+      authClient["transactionStore"].save = vi.fn(
+        async (cookies, transactionState) => {
+          expect(transactionState).toEqual(
+            expect.objectContaining({
+              nonce: expect.any(String),
+              codeVerifier: expect.any(String),
+              responseType: "code",
+              state: expect.any(String),
+              returnTo: "https://example.com/custom-path"
+            })
+          );
+          return originalSave.call(
+            authClient["transactionStore"],
+            cookies,
+            transactionState
+          );
+        }
+      );
 
       await authClient.startInteractiveLogin({ returnTo });
-      
-      expect(authClient['transactionStore'].save).toHaveBeenCalled();
+
+      expect(authClient["transactionStore"].save).toHaveBeenCalled();
     });
 
     it("should merge configuration authorizationParameters with method arguments", async () => {
@@ -4509,13 +4529,13 @@ ca/T0LLtgmbMmxSv/MmzIg==
           audience: configAudience
         }
       });
-      
+
       const methodScope = "openid profile email custom_scope";
       const methodAudience = "https://custom-api.example.com";
-      
+
       // Spy on the authorizationUrl method to verify the passed params
-      const originalAuthorizationUrl = authClient['authorizationUrl'];
-      authClient['authorizationUrl'] = vi.fn(async (params) => {
+      const originalAuthorizationUrl = authClient["authorizationUrl"];
+      authClient["authorizationUrl"] = vi.fn(async (params) => {
         // Method's authorization parameters should override config
         expect(params.get("audience")).toBe(methodAudience);
         expect(params.get("scope")).toBe(methodScope);
@@ -4528,14 +4548,14 @@ ca/T0LLtgmbMmxSv/MmzIg==
           audience: methodAudience
         }
       });
-      
-      expect(authClient['authorizationUrl']).toHaveBeenCalled();
+
+      expect(authClient["authorizationUrl"]).toHaveBeenCalled();
     });
 
     // Add tests for handleLogin method
     it("should create correct options in handleLogin with returnTo parameter", async () => {
       const authClient = await createAuthClient();
-      
+
       // Mock startInteractiveLogin to check what options are passed to it
       const originalStartInteractiveLogin = authClient.startInteractiveLogin;
       authClient.startInteractiveLogin = vi.fn(async (options) => {
@@ -4546,19 +4566,21 @@ ca/T0LLtgmbMmxSv/MmzIg==
         return originalStartInteractiveLogin.call(authClient, options);
       });
 
-      const reqUrl = new URL("https://example.com/auth/login?foo=bar&returnTo=custom-return");
+      const reqUrl = new URL(
+        "https://example.com/auth/login?foo=bar&returnTo=custom-return"
+      );
       const req = new NextRequest(reqUrl, { method: "GET" });
-      
+
       await authClient.handleLogin(req);
-      
+
       expect(authClient.startInteractiveLogin).toHaveBeenCalled();
     });
 
     it("should handle PAR correctly in handleLogin by not forwarding params", async () => {
       const authClient = await createAuthClient({
         pushedAuthorizationRequests: true
       });
-      
+
       // Mock startInteractiveLogin to check what options are passed to it
       const originalStartInteractiveLogin = authClient.startInteractiveLogin;
       authClient.startInteractiveLogin = vi.fn(async (options) => {
@@ -4569,11 +4591,13 @@ ca/T0LLtgmbMmxSv/MmzIg==
         return originalStartInteractiveLogin.call(authClient, options);
       });
 
-      const reqUrl = new URL("https://example.com/auth/login?foo=bar&returnTo=custom-return");
+      const reqUrl = new URL(
+        "https://example.com/auth/login?foo=bar&returnTo=custom-return"
+      );
       const req = new NextRequest(reqUrl, { method: "GET" });
-      
+
       await authClient.handleLogin(req);
-      
+
       expect(authClient.startInteractiveLogin).toHaveBeenCalled();
     });
   });

src/server/auth-client.ts

@@ -6,21 +6,21 @@ import packageJson from "../../package.json";
 import {
   AccessTokenError,
   AccessTokenErrorCode,
+  AccessTokenForConnectionError,
+  AccessTokenForConnectionErrorCode,
   AuthorizationCodeGrantError,
   AuthorizationError,
   BackchannelLogoutError,
   DiscoveryError,
-  AccessTokenForConnectionError,
-  AccessTokenForConnectionErrorCode,
   InvalidStateError,
   MissingStateError,
   OAuth2Error,
   SdkError
 } from "../errors";
 import {
+  AccessTokenForConnectionOptions,
   AuthorizationParameters,
   ConnectionTokenSet,
-  AccessTokenForConnectionOptions,
   LogoutToken,
   SessionData,
   StartInteractiveLoginOptions,
@@ -65,7 +65,6 @@ const DEFAULT_SCOPES = ["openid", "profile", "email", "offline_access"].join(
   " "
 );
 
-
 /**
  * A constant representing the grant type for federated connection access token exchange.
  *
@@ -1016,19 +1015,20 @@ export class AuthClient {
     tokenSet: TokenSet,
     connectionTokenSet: ConnectionTokenSet | undefined,
     options: AccessTokenForConnectionOptions
-  ): Promise<[AccessTokenForConnectionError, null] | [null, ConnectionTokenSet]> {
+  ): Promise<
+    [AccessTokenForConnectionError, null] | [null, ConnectionTokenSet]
+  > {
     // If we do not have a refresh token
     // and we do not have a connection token set in the cache or the one we have is expired,
     // there is noting to retrieve and we return an error.
     if (
       !tokenSet.refreshToken &&
-      (!connectionTokenSet ||
-        connectionTokenSet.expiresAt <= Date.now() / 1000)
+      (!connectionTokenSet || connectionTokenSet.expiresAt <= Date.now() / 1000)
     ) {
       return [
         new AccessTokenForConnectionError(
           AccessTokenForConnectionErrorCode.MISSING_REFRESH_TOKEN,
-          "A refresh token was not present, Connection Access Token requires a refresh token. The user needs to re-authenticate.",
+          "A refresh token was not present, Connection Access Token requires a refresh token. The user needs to re-authenticate."
         ),
         null
       ];
@@ -1039,8 +1039,7 @@ export class AuthClient {
     // we need to exchange the refresh token for a connection access token.
     if (
       tokenSet.refreshToken &&
-      (!connectionTokenSet ||
-        connectionTokenSet.expiresAt <= Date.now() / 1000)
+      (!connectionTokenSet || connectionTokenSet.expiresAt <= Date.now() / 1000)
     ) {
       const params = new URLSearchParams();
 
@@ -1111,10 +1110,7 @@ export class AuthClient {
       ];
     }
 
-    return [null, connectionTokenSet] as [
-      null,
-      ConnectionTokenSet
-    ];
+    return [null, connectionTokenSet] as [null, ConnectionTokenSet];
   }
 }
 

src/server/session/stateful-session-store.test.ts

@@ -690,7 +690,6 @@ describe("Stateful Session Store", async () => {
       });
     });
 
-
     it("should remove the legacy cookie if it exists", async () => {
       const currentTime = Date.now();
       const createdAt = Math.floor(currentTime / 1000);
@@ -718,7 +717,7 @@ describe("Stateful Session Store", async () => {
 
       const sessionStore = new StatefulSessionStore({
         secret,
-        store,
+        store
       });
 
       vi.spyOn(requestCookies, "has").mockReturnValue(true);