Skip to content

fix: stop importing named export from package.json#1962

Merged
tusharpandey13 merged 2 commits intomainfrom
bugfix/fix-named-export-error
Mar 13, 2025
Merged

fix: stop importing named export from package.json#1962
tusharpandey13 merged 2 commits intomainfrom
bugfix/fix-named-export-error

Conversation

@tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Mar 13, 2025

Duplicate of #1960, thanks @mogzol

Importing the 'version' named export from package.json caused errors
during webpack builds for apps using this package (#1955). Instead,
this imports the default export as 'packageJson', and then gets the
version with 'packageJson.version'.

Tests: PASSING
Build: PASSING

Importing the 'version' named export from package.json caused errors
during webpack builds for apps using this package (#1955). Instead,
this imports the default export as 'packageJson', and then gets the
version with 'packageJson.version'.
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (2ac2d31) to head (9d0bf58).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
+ Coverage   76.14%   76.16%   +0.01%     
==========================================
  Files          21       21              
  Lines        1522     1523       +1     
  Branches      242      242              
==========================================
+ Hits         1159     1160       +1     
  Misses        356      356              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tusharpandey13 tusharpandey13 merged commit c804da6 into main Mar 13, 2025
12 checks passed
@tusharpandey13 tusharpandey13 deleted the bugfix/fix-named-export-error branch March 13, 2025 09:28
@tusharpandey13 tusharpandey13 mentioned this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments