Skip to content

fix: do not throw ERR_JWE_DECRYPTION_FAILED, but catch it and ignore the cookie. #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nandan-bhat merged 3 commits into from
Jan 23, 2026
Merged

fix: do not throw ERR_JWE_DECRYPTION_FAILED, but catch it and ignore the cookie. #2487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba49e16
fix: do not throw ERR_JWE_DECRYPTION_FAILED, but catch it and ignore …
frederikprijck Jan 13, 2026
2bf9505
fix lint
frederikprijck Jan 13, 2026
631464a
Merge branch 'main' into chore/handle-invalid-jwe
frederikprijck Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/server/cookies.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@ describe("encrypt/decrypt", async () => {
const maxAge = 60 * 60; // 1 hour in seconds
const expiration = Math.floor(Date.now() / 1000 + maxAge);
const encrypted = await encrypt(payload, secret, expiration);
await expect(() =>
decrypt(encrypted, incorrectSecret)
).rejects.toThrowError();
const decrypted = await decrypt(encrypted, incorrectSecret);
expect(decrypted).toBeNull();
});

it("should fail to decrypt when expired", async () => {
Expand Down
6 changes: 5 additions & 1 deletion src/server/cookies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ export async function decrypt<T>(

return cookie;
} catch (e: any) {
if (e.code === "ERR_JWT_EXPIRED") {
// When the JWE can not be decrypted or has expired, return null to indicate an invalid cookie and treat it as non-existent.
if (
e.code === "ERR_JWE_DECRYPTION_FAILED" ||
e.code === "ERR_JWT_EXPIRED"
) {
return null;
}
throw e;
Expand Down