chore: apply feedback

Author: guabu

EXAMPLES.md

@@ -165,7 +165,7 @@ const auth = new AuthenticationClient({
 
 const { data: token } = await auth.oauth.tokenForConnection({
   subject_token: '{refresh_token}',
-  subject_token_type: SUBJECT_TOKEN_TYPES.SUBJECT_TYPE_REFRESH_TOKEN, // Optional: defaults to refresh token type
+  subject_token_type: SUBJECT_TOKEN_TYPES.REFRESH_TOKEN, // Optional: defaults to refresh token type
   connection: 'google-oauth2', // The target social provider connection
   login_hint: 'user@example.com', // Optional: to target a specific account
 });

src/auth/oauth.ts

@@ -310,22 +310,22 @@ export enum SUBJECT_TOKEN_TYPES {
    *
    * @see {@link https://tools.ietf.org/html/rfc8693#section-3.1 RFC 8693 Section 3.1}
    */
-  SUBJECT_TYPE_REFRESH_TOKEN = 'urn:ietf:params:oauth:token-type:refresh_token',
+  REFRESH_TOKEN = 'urn:ietf:params:oauth:token-type:refresh_token',
 
   /**
    * Constant representing the subject type for a access token.
    * This is used in OAuth 2.0 token exchange to specify that the token being exchanged is an access token.
    *
    * @see {@link https://tools.ietf.org/html/rfc8693#section-3.1 RFC 8693 Section 3.1}
    */
-  SUBJECT_TYPE_ACCESS_TOKEN = 'urn:ietf:params:oauth:token-type:access_token',
+  ACCESS_TOKEN = 'urn:ietf:params:oauth:token-type:access_token',
 }
 
 export const TOKEN_FOR_CONNECTION_GRANT_TYPE =
   'urn:auth0:params:oauth:grant-type:token-exchange:federated-connection-access-token';
 
 /**
- * @deprecated Use {@link SUBJECT_TOKEN_TYPES.SUBJECT_TYPE_REFRESH_TOKEN} instead.
+ * @deprecated Use {@link SUBJECT_TOKEN_TYPES.REFRESH_TOKEN} instead.
  */
 export const TOKEN_FOR_CONNECTION_TOKEN_TYPE = 'urn:ietf:params:oauth:token-type:refresh_token';
 export const TOKEN_FOR_CONNECTION_REQUESTED_TOKEN_TYPE =
@@ -636,16 +636,10 @@ export class OAuth extends BaseAuthAPI {
   ): Promise<JSONApiResponse<TokenSet>> {
     validateRequiredRequestParams(bodyParameters, ['connection', 'subject_token']);
 
-    let subjectTokenType = SUBJECT_TOKEN_TYPES.SUBJECT_TYPE_REFRESH_TOKEN;
-
-    if (bodyParameters.subject_token_type) {
-      subjectTokenType = bodyParameters.subject_token_type;
-    }
-
     const body: Record<string, string> = {
+      subject_token_type: SUBJECT_TOKEN_TYPES.REFRESH_TOKEN,
       ...bodyParameters,
       grant_type: TOKEN_FOR_CONNECTION_GRANT_TYPE,
-      subject_token_type: subjectTokenType,
       requested_token_type: TOKEN_FOR_CONNECTION_REQUESTED_TOKEN_TYPE,
     };
 

test/auth/fixtures/oauth.json

@@ -194,7 +194,7 @@
     "scope": "https://test-domain.auth0.com",
     "method": "POST",
     "path": "/oauth/token",
-    "body": "connection=google-oauth2&subject_token=test-refresh-token&grant_type=urn%3Aauth0%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange%3Afederated-connection-access-token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Arefresh_token&requested_token_type=http%3A%2F%2Fauth0.com%2Foauth%2Ftoken-type%2Ffederated-connection-access-token&client_secret=test-client-secret",
+    "body": "subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Arefresh_token&connection=google-oauth2&subject_token=test-refresh-token&grant_type=urn%3Aauth0%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange%3Afederated-connection-access-token&requested_token_type=http%3A%2F%2Fauth0.com%2Foauth%2Ftoken-type%2Ffederated-connection-access-token&client_secret=test-client-secret",
     "status": 200,
     "response": {
       "access_token": "connection-access-token",
@@ -206,7 +206,7 @@
     "scope": "https://test-domain.auth0.com",
     "method": "POST",
     "path": "/oauth/token",
-    "body": "connection=google-oauth2&subject_token=test-refresh-token&login_hint=user%40example.com&grant_type=urn%3Aauth0%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange%3Afederated-connection-access-token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Arefresh_token&requested_token_type=http%3A%2F%2Fauth0.com%2Foauth%2Ftoken-type%2Ffederated-connection-access-token&client_secret=test-client-secret",
+    "body": "subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Arefresh_token&connection=google-oauth2&subject_token=test-refresh-token&login_hint=user%40example.com&grant_type=urn%3Aauth0%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange%3Afederated-connection-access-token&requested_token_type=http%3A%2F%2Fauth0.com%2Foauth%2Ftoken-type%2Ffederated-connection-access-token&client_secret=test-client-secret",
     "status": 200,
     "response": {
       "access_token": "connection-access-token",
@@ -218,7 +218,7 @@
     "scope": "https://test-domain.auth0.com",
     "method": "POST",
     "path": "/oauth/token",
-    "body": "connection=google-oauth2&subject_token=test-id-token&subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&grant_type=urn%3Aauth0%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange%3Afederated-connection-access-token&requested_token_type=http%3A%2F%2Fauth0.com%2Foauth%2Ftoken-type%2Ffederated-connection-access-token&client_secret=test-client-secret",
+    "body": "subject_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Aaccess_token&connection=google-oauth2&subject_token=test-id-token&grant_type=urn%3Aauth0%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange%3Afederated-connection-access-token&requested_token_type=http%3A%2F%2Fauth0.com%2Foauth%2Ftoken-type%2Ffederated-connection-access-token&client_secret=test-client-secret",
     "status": 200,
     "response": {
       "access_token": "connection-access-token",

test/auth/oauth.test.ts

@@ -426,7 +426,7 @@ describe('OAuth', () => {
         oauth.tokenForConnection({
           connection: 'google-oauth2',
           subject_token: 'test-id-token',
-          subject_token_type: SUBJECT_TOKEN_TYPES.SUBJECT_TYPE_ACCESS_TOKEN,
+          subject_token_type: SUBJECT_TOKEN_TYPES.ACCESS_TOKEN,
         })
       ).resolves.toMatchObject({
         data: {