Skip to content

Commit 06acc02

Browse files
siacomuzziforrest-ua
authored andcommitted
feat: fix sec issues with dependencies
BREAKING CHANGE: xml-encryption major version bump, fix typo in config property from `keyEncryptionAlgorighm` to `keyEncryptionAlgorithm` consumed by new xml-encryption library version.
1 parent a08d250 commit 06acc02

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

lib/saml11.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function extractSaml11Options(opts) {
5555
* @param [options.encryptionCert] {Buffer}
5656
* @param [options.encryptionPublicKey] {Buffer}
5757
* @param [options.encryptionAlgorithm] {string}
58-
* @param [options.keyEncryptionAlgorighm] {string}
58+
* @param [options.keyEncryptionAlgorithm] {string}
5959
*
6060
* @param {Function} [callback] required if encrypting
6161
* @return {String|*}
@@ -88,7 +88,7 @@ exports.create = function(options, callback) {
8888
* @param [options.encryptionCert] {Buffer}
8989
* @param [options.encryptionPublicKey] {Buffer}
9090
* @param [options.encryptionAlgorithm] {string}
91-
* @param [options.keyEncryptionAlgorighm] {string}
91+
* @param [options.keyEncryptionAlgorithm] {string}
9292
*
9393
* @param {Function} [callback] required if encrypting
9494
* @return {String|*}

lib/saml20.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ function extractSaml20Options(opts) {
9494
* @param [options.encryptionCert] {Buffer}
9595
* @param [options.encryptionPublicKey] {Buffer}
9696
* @param [options.encryptionAlgorithm] {string}
97-
* @param [options.keyEncryptionAlgorighm] {string}
97+
* @param [options.keyEncryptionAlgorithm] {string}
9898
*
9999
* @param {Function} [callback] required if encrypting
100100
* @return {*}
@@ -133,7 +133,7 @@ exports.create = function createSignedAssertion(options, callback) {
133133
* @param [options.encryptionCert] {Buffer}
134134
* @param [options.encryptionPublicKey] {Buffer}
135135
* @param [options.encryptionAlgorithm] {string}
136-
* @param [options.keyEncryptionAlgorighm] {string}
136+
* @param [options.keyEncryptionAlgorithm] {string}
137137
*
138138
* @param {Function} [callback] required if encrypting
139139
* @return {*}

lib/xml/encrypt.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ exports.fromEncryptXmlOptions = function (options) {
1010
rsa_pub: options.encryptionPublicKey,
1111
pem: options.encryptionCert,
1212
encryptionAlgorithm: options.encryptionAlgorithm || 'http://www.w3.org/2001/04/xmlenc#aes256-cbc',
13-
keyEncryptionAlgorighm: options.keyEncryptionAlgorighm || 'http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p',
13+
keyEncryptionAlgorithm: options.keyEncryptionAlgorithm || 'http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p',
1414
};
1515

1616
// expose the encryptOptions as these are needed when adding the SubjectConfirmation

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
"name": "saml",
33
"version": "0.15.0",
44
"devDependencies": {
5-
"@commitlint/cli": "^9.1.2",
6-
"@commitlint/config-conventional": "^9.1.2",
5+
"@commitlint/cli": "^11.0.0",
6+
"@commitlint/config-conventional": "^11.0.0",
77
"chai": "^4.2.0",
88
"husky": "^4.3.0",
9-
"mocha": "3.5.3",
9+
"mocha": "^8.2.0",
1010
"should": "~1.2.1",
1111
"standard-version": "^9.0.0"
1212
},
@@ -23,7 +23,7 @@
2323
"moment": "2.19.3",
2424
"valid-url": "~1.0.9",
2525
"xml-crypto": "~1.0.1",
26-
"xml-encryption": "0.11.2",
26+
"xml-encryption": "^1.2.1",
2727
"xml-name-validator": "~2.0.1",
2828
"xmldom": "=0.1.15",
2929
"xpath": "0.0.5"

0 commit comments

Comments
 (0)