Skip to content

Commit 5f523fd

Browse files
Document a trap of dart format
1 parent e0d0956 commit 5f523fd

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

.github/workflows/ci.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ jobs:
2929
- run: make example-flutter-pub-get
3030
- run: make example-flutter-test
3131
- run: make example-flutter-analyze
32+
# It is extremely important that you have `pub get` run before `dart format`.
33+
# Otherwise, the result is unpredictable.
34+
# https://github.com/dart-lang/sdk/issues/60163#issuecomment-2680372038
3235
- run: make example-dart-format
3336
- run: make example-pod-install
3437
- run: make example-build-unsigned-ios-app
@@ -50,6 +53,9 @@ jobs:
5053
- run: make example-flutter-pub-get
5154
- run: make example-flutter-test
5255
- run: make example-flutter-analyze
56+
# It is extremely important that you have `pub get` run before `dart format`.
57+
# Otherwise, the result is unpredictable.
58+
# https://github.com/dart-lang/sdk/issues/60163#issuecomment-2680372038
5359
- run: make example-dart-format
5460
- run: make example-build-unsigned-android-aab
5561

@@ -68,6 +74,9 @@ jobs:
6874
- run: make sdk-flutter-pub-get
6975
- run: make sdk-flutter-test
7076
- run: make sdk-flutter-analyze
77+
# It is extremely important that you have `pub get` run before `dart format`.
78+
# Otherwise, the result is unpredictable.
79+
# https://github.com/dart-lang/sdk/issues/60163#issuecomment-2680372038
7180
- run: make sdk-dart-format
7281
# Install the latest dartdoc to avoid a bug
7382
# See DEVELOPER.md
@@ -100,6 +109,9 @@ jobs:
100109
- run: make example-flutter-pub-get
101110
- run: make example-flutter-test
102111
- run: make example-flutter-analyze
112+
# It is extremely important that you have `pub get` run before `dart format`.
113+
# Otherwise, the result is unpredictable.
114+
# https://github.com/dart-lang/sdk/issues/60163#issuecomment-2680372038
103115
- run: make example-dart-format
104116
- run: make example-pod-install
105117
- uses: authgear/gh-actions-install-apple-certificate-and-provisioning-profile@v1
@@ -140,6 +152,9 @@ jobs:
140152
- run: make example-flutter-pub-get
141153
- run: make example-flutter-test
142154
- run: make example-flutter-analyze
155+
# It is extremely important that you have `pub get` run before `dart format`.
156+
# Otherwise, the result is unpredictable.
157+
# https://github.com/dart-lang/sdk/issues/60163#issuecomment-2680372038
143158
- run: make example-dart-format
144159
- name: Build aab
145160
if: ${{ github.ref == 'refs/heads/main' }}

0 commit comments

Comments
 (0)