Fix signup rate limit

louischan-oursky · louischan-oursky · commit 4dbfcffb3447 · 2023-08-11T16:53:18.000+08:00
When rate limited, the nil err is always returned.
diff --git a/pkg/lib/interaction/nodes/do_create_user.go b/pkg/lib/interaction/nodes/do_create_user.go
@@ -86,7 +86,7 @@ func (n *NodeDoCreateUser) GetEffects() ([]interaction.Effect, error) {
 				// check the rate limit only before running the effects
 				bucket := interaction.SignupPerIPRateLimitBucketSpec(ctx.Config.Authentication, isAnonymous, ip)
 				reservation = ctx.RateLimiter.Reserve(bucket)
-				if reservation.Error() != nil {
+				if err := reservation.Error(); err != nil {
 					return err
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func (n *NodeDoCreateUser) GetEffects() ([]interaction.Effect, error) {`
`86`	`86`	`// check the rate limit only before running the effects`
`87`	`87`	`bucket := interaction.SignupPerIPRateLimitBucketSpec(ctx.Config.Authentication, isAnonymous, ip)`
`88`	`88`	`reservation = ctx.RateLimiter.Reserve(bucket)`
`89`		`- if reservation.Error() != nil {`
	`89`	`+ if err := reservation.Error(); err != nil {`
`90`	`90`	`return err`
`91`	`91`	`}`
`92`	`92`	`}`