Skip to content

Commit d2a4830

Browse files
author
Graham Butler
committed
fix error handling
1 parent 31da24d commit d2a4830

File tree

2 files changed

+29
-20
lines changed

2 files changed

+29
-20
lines changed

NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Add cloak

src/element.js

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -806,34 +806,42 @@ const AuthorBaseElement = superClass => class extends superClass {
806806
let error = new Error()
807807
let { vars } = properties
808808

809-
if (type === 'dependency') {
810-
finalMessage += 'Missing dependency'
809+
switch (type) {
810+
case 'custom': break
811811

812-
if (vars) {
813-
if (vars.hasOwnProperty('name')) {
814-
finalMessage += `: ${vars.name}`
815-
}
812+
case 'dependency':
813+
finalMessage += 'Missing dependency'
814+
815+
if (vars) {
816+
if (vars.hasOwnProperty('name')) {
817+
finalMessage += `: ${vars.name}`
818+
}
816819

817-
if (vars.hasOwnProperty('url')) {
818-
finalMessage += ` ${vars.url}`
820+
if (vars.hasOwnProperty('url')) {
821+
finalMessage += ` ${vars.url}`
822+
}
819823
}
820-
}
821824

822-
} else if (type === 'readonly') {
823-
finalMessage += `Cannot set read-only property`
825+
break
824826

825-
if (vars && vars.hasOwnProperty('prop')) {
826-
finalMessage += ` "${vars.prop}"`
827-
}
827+
case 'readonly':
828+
finalMessage += `Cannot set read-only property`
828829

829-
} else if (type === 'reference') {
830-
error = new ReferenceError()
830+
if (vars && vars.hasOwnProperty('prop')) {
831+
finalMessage += ` "${vars.prop}"`
832+
}
831833

832-
} else if (type === 'type') {
833-
error = new TypeError()
834+
break
834835

835-
} else {
836-
return this.UTIL.throwError({
836+
case 'reference':
837+
error = new ReferenceError()
838+
break
839+
840+
case 'type':
841+
error = new TypeError()
842+
break
843+
844+
default: return this.UTIL.throwError({
837845
message: `Unrecognized error type "${type}". Accepted types: "custom", "dependency", "readonly", "reference", "type"`
838846
})
839847
}

0 commit comments

Comments
 (0)