Skip to content

Commit 252cd1f

Browse files
committed
fix: make code_challenge optional
1 parent 7c2693b commit 252cd1f

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

server/handlers/authorize.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func AuthorizeHandler() gin.HandlerFunc {
6464

6565
if err := validateAuthorizeRequest(responseType, responseMode, clientID, state, codeChallenge); err != nil {
6666
log.Debug("invalid authorization request: ", err)
67-
gc.JSON(http.StatusBadRequest, gin.H{"error": err})
67+
gc.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
6868
return
6969
}
7070

@@ -270,10 +270,6 @@ func validateAuthorizeRequest(responseType, responseMode, clientID, state, codeC
270270
return fmt.Errorf("invalid response mode %s. 'query', 'fragment', 'form_post' and 'web_message' are valid response_mode", responseMode)
271271
}
272272

273-
if responseType == constants.ResponseTypeCode && strings.TrimSpace(codeChallenge) == "" {
274-
return fmt.Errorf("code_challenge is required for %s '%s'", responseType, constants.ResponseTypeCode)
275-
}
276-
277273
if client, err := memorystore.Provider.GetStringStoreEnvVariable(constants.EnvKeyClientID); client != clientID || err != nil {
278274
return fmt.Errorf("invalid client_id %s", clientID)
279275
}

0 commit comments

Comments
 (0)