Skip to content

Commit 3868157

Browse files
author
darshvaghela
committed
refactored code
1 parent d693c05 commit 3868157

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

dashboard/src/components/EnvComponents/Features.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const Features = ({ variables, setVariables }: any) => {
2020
variables={variables}
2121
setVariables={setVariables}
2222
inputType={SwitchInputType.DISABLE_LOGIN_PAGE}
23-
is_Disable={true}
23+
hasReversedValue
2424
/>
2525
</Flex>
2626
</Flex>
@@ -33,7 +33,7 @@ const Features = ({ variables, setVariables }: any) => {
3333
variables={variables}
3434
setVariables={setVariables}
3535
inputType={SwitchInputType.DISABLE_EMAIL_VERIFICATION}
36-
is_Disable={true}
36+
hasReversedValue
3737
/>
3838
</Flex>
3939
</Flex>
@@ -46,7 +46,7 @@ const Features = ({ variables, setVariables }: any) => {
4646
variables={variables}
4747
setVariables={setVariables}
4848
inputType={SwitchInputType.DISABLE_MAGIC_LINK_LOGIN}
49-
is_Disable={true}
49+
hasReversedValue
5050
/>
5151
</Flex>
5252
</Flex>
@@ -59,7 +59,7 @@ const Features = ({ variables, setVariables }: any) => {
5959
variables={variables}
6060
setVariables={setVariables}
6161
inputType={SwitchInputType.DISABLE_BASIC_AUTHENTICATION}
62-
is_Disable={true}
62+
hasReversedValue
6363
/>
6464
</Flex>
6565
</Flex>
@@ -72,7 +72,7 @@ const Features = ({ variables, setVariables }: any) => {
7272
variables={variables}
7373
setVariables={setVariables}
7474
inputType={SwitchInputType.DISABLE_SIGN_UP}
75-
is_Disable={true}
75+
hasReversedValue
7676
/>
7777
</Flex>
7878
</Flex>
@@ -85,7 +85,7 @@ const Features = ({ variables, setVariables }: any) => {
8585
variables={variables}
8686
setVariables={setVariables}
8787
inputType={SwitchInputType.DISABLE_STRONG_PASSWORD}
88-
is_Disable={true}
88+
hasReversedValue
8989
/>
9090
</Flex>
9191
</Flex>
@@ -102,7 +102,7 @@ const Features = ({ variables, setVariables }: any) => {
102102
variables={variables}
103103
setVariables={setVariables}
104104
inputType={SwitchInputType.DISABLE_MULTI_FACTOR_AUTHENTICATION}
105-
is_Disable={true}
105+
hasReversedValue
106106
/>
107107
</Flex>
108108
</Flex>
@@ -121,7 +121,6 @@ const Features = ({ variables, setVariables }: any) => {
121121
variables={variables}
122122
setVariables={setVariables}
123123
inputType={SwitchInputType.ENFORCE_MULTI_FACTOR_AUTHENTICATION}
124-
is_Disable={false}
125124
/>
126125
</Flex>
127126
</Flex>

dashboard/src/components/InputField.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ const InputField = ({
4848
fieldVisibility,
4949
setFieldVisibility,
5050
availableRoles,
51-
is_Disable,
51+
// This prop is added to improve the user experience for the boolean ENV variable having `DISABLE_` prefix, as those values need to be considered in inverted form.
52+
hasReversedValue,
5253
...downshiftProps
5354
}: any) => {
5455
const props = {
@@ -399,7 +400,9 @@ const InputField = ({
399400
</Text>
400401
<Switch
401402
size="md"
402-
isChecked={is_Disable ? !variables[inputType] : variables[inputType]}
403+
isChecked={
404+
hasReversedValue ? !variables[inputType] : variables[inputType]
405+
}
403406
onChange={() => {
404407
setVariables({
405408
...variables,

0 commit comments

Comments
 (0)