Skip to content

Commit 9936938

Browse files
committed
fix: scope for github auth
1 parent ed849fa commit 9936938

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

server/handlers/oauth_callback.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -287,9 +287,9 @@ func processGithubUserInfo(code string) (models.User, error) {
287287
log.Debug("Failed to create github user info request: ", err)
288288
return user, fmt.Errorf("error creating github user info request: %s", err.Error())
289289
}
290-
req.Header = http.Header{
291-
"Authorization": []string{fmt.Sprintf("token %s", oauth2Token.AccessToken)},
292-
}
290+
req.Header.Set(
291+
"Authorization", fmt.Sprintf("token %s", oauth2Token.AccessToken),
292+
)
293293

294294
response, err := client.Do(req)
295295
if err != nil {
@@ -331,14 +331,14 @@ func processGithubUserInfo(code string) (models.User, error) {
331331
}
332332

333333
// fetch using /users/email endpoint
334-
req, err := http.NewRequest("GET", constants.GithubUserEmails, nil)
334+
req, err := http.NewRequest(http.MethodGet, constants.GithubUserEmails, nil)
335335
if err != nil {
336336
log.Debug("Failed to create github emails request: ", err)
337337
return user, fmt.Errorf("error creating github user info request: %s", err.Error())
338338
}
339-
req.Header = http.Header{
340-
"Authorization": []string{fmt.Sprintf("token %s", oauth2Token.AccessToken)},
341-
}
339+
req.Header.Set(
340+
"Authorization", fmt.Sprintf("token %s", oauth2Token.AccessToken),
341+
)
342342

343343
response, err := client.Do(req)
344344
if err != nil {

server/oauth/oauth.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ func InitOAuth() error {
7575
ClientSecret: githubClientSecret,
7676
RedirectURL: "/oauth_callback/github",
7777
Endpoint: githubOAuth2.Endpoint,
78+
Scopes: []string{"read:user", "user:email"},
7879
}
7980
}
8081

0 commit comments

Comments
 (0)