Skip to content

Commit c128f7e

Browse files
committed
fix: add code to query params + fix openid config
1 parent d8ecead commit c128f7e

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

app/src/Root.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export default function Root({
3838
const scope = searchParams.get('scope')
3939
? searchParams.get('scope')?.toString().split(' ')
4040
: ['openid', 'profile', 'email'];
41+
const code = searchParams.get('code')
4142

4243
const urlProps: Record<string, any> = {
4344
state,
@@ -58,6 +59,10 @@ export default function Root({
5859
if (token) {
5960
let redirectURL = config.redirectURL || '/app';
6061
let params = `access_token=${token.access_token}&id_token=${token.id_token}&expires_in=${token.expires_in}&state=${globalState.state}`;
62+
63+
if (code) {
64+
params += `&code=${code}`
65+
}
6166
if (token.refresh_token) {
6267
params += `&refresh_token=${token.refresh_token}`;
6368
}

server/handlers/authorize.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,9 @@ func AuthorizeHandler() gin.HandlerFunc {
5858
}
5959

6060
isQuery := responseMode == "query"
61+
code := uuid.New().String()
6162

62-
loginURL := "/app?state=" + state + "&scope=" + strings.Join(scope, " ") + "&redirect_uri=" + redirectURI
63+
loginURL := "/app?state=" + state + "&scope=" + strings.Join(scope, " ") + "&redirect_uri=" + redirectURI + "&code=" + code
6364

6465
if clientID == "" {
6566
if isQuery {
@@ -250,7 +251,7 @@ func AuthorizeHandler() gin.HandlerFunc {
250251

251252
memorystore.Provider.SetUserSession(sessionKey, constants.TokenTypeSessionToken+"_"+newSessionTokenData.Nonce, newSessionToken)
252253
cookie.SetSession(gc, newSessionToken)
253-
code := uuid.New().String()
254+
254255
memorystore.Provider.SetState(codeChallenge, code+"@"+newSessionToken)
255256
gc.HTML(http.StatusOK, template, gin.H{
256257
"target_origin": redirectURI,
@@ -297,7 +298,7 @@ func AuthorizeHandler() gin.HandlerFunc {
297298
}
298299

299300
// used of query mode
300-
params := "access_token=" + authToken.AccessToken.Token + "&token_type=bearer&expires_in=" + strconv.FormatInt(expiresIn, 10) + "&state=" + state + "&id_token=" + authToken.IDToken.Token
301+
params := "access_token=" + authToken.AccessToken.Token + "&token_type=bearer&expires_in=" + strconv.FormatInt(expiresIn, 10) + "&state=" + state + "&id_token=" + authToken.IDToken.Token + "&code=" + code
301302

302303
res := map[string]interface{}{
303304
"access_token": authToken.AccessToken.Token,
@@ -306,6 +307,7 @@ func AuthorizeHandler() gin.HandlerFunc {
306307
"scope": scope,
307308
"token_type": "Bearer",
308309
"expires_in": expiresIn,
310+
"code": code,
309311
}
310312

311313
if authToken.RefreshToken != nil {

server/handlers/openid_config.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ func OpenIDConfigurationHandler() gin.HandlerFunc {
1717
c.JSON(200, gin.H{
1818
"issuer": issuer,
1919
"authorization_endpoint": issuer + "/authorize",
20-
"token_endpoint": issuer + "/token",
20+
"token_endpoint": issuer + "/oauth/token",
2121
"userinfo_endpoint": issuer + "/userinfo",
2222
"jwks_uri": issuer + "/.well-known/jwks.json",
23-
"response_types_supported": []string{"code", "token", "id_token", "code token", "code id_token", "token id_token", "code token id_token"},
23+
"response_types_supported": []string{"code", "token", "id_token"},
2424
"scopes_supported": []string{"openid", "email", "profile", "email_verified", "given_name", "family_name", "nick_name", "picture"},
2525
"response_modes_supported": []string{"query", "fragment", "form_post"},
2626
"id_token_signing_alg_values_supported": []string{jwtType},
27-
"claims_supported": []string{"aud", "exp", "iss", "iat", "sub", "given_name", "family_name", "middle_name", "nickname", "preferred_username", "picture", "email", "email_verified", "roles", "gender", "birthdate", "phone_number", "phone_number_verified"},
27+
"claims_supported": []string{"aud", "exp", "iss", "iat", "sub", "given_name", "family_name", "middle_name", "nickname", "preferred_username", "picture", "email", "email_verified", "roles", "role", "gender", "birthdate", "phone_number", "phone_number_verified", "nonce", "updated_at", "created_at", "revoked_timestamp", "login_method", "signup_methods", "token_type"},
2828
})
2929
}
3030
}

0 commit comments

Comments
 (0)