chore: unhide the --experimental-query-plan flag (#2842)

Author: barakmich

docs/spicedb.md

@@ -514,6 +514,7 @@ spicedb serve [flags]
       --experimental-dispatch-secondary-upstream-addrs stringToString                   secondary upstream addresses for dispatches, each with a name (default [])
       --experimental-dispatch-secondary-upstream-exprs stringToString                   map from request type to its associated CEL expression, which returns the secondary upstream(s) to be used for the request (default [])
       --experimental-lookup-resources-version lr3                                       if non-empty, the version of the experimental lookup resources API to use: lr3 or empty
+      --experimental-query-plan check                                                   if non-empty, the version of the experimental query plan to use: check or empty
       --grpc-addr string                                                                address to listen on to serve gRPC (default ":50051")
       --grpc-enabled                                                                    enable gRPC gRPC server (default true)
       --grpc-log-requests-enabled                                                       enable logging of API request payloads

internal/services/v1/permissions_queryplan.go

@@ -52,6 +52,12 @@ func (ps *permissionServer) checkPermissionWithQueryPlan(ctx context.Context, re
 		return nil, ps.rewriteError(ctx, err)
 	}
 
+	// Apply basic optimizations to the iterator tree
+	it, _, err = query.ApplyOptimizations(it, query.StaticOptimizations)
+	if err != nil {
+		return nil, ps.rewriteError(ctx, err)
+	}
+
 	// Parse caveat context if provided
 	caveatContext, err := GetCaveatContext(ctx, req.Context, ps.config.MaxCaveatContextSize)
 	if err != nil {

pkg/cmd/serve.go

@@ -168,9 +168,6 @@ func RegisterServeFlags(cmd *cobra.Command, config *server.Config) error {
 	experimentalFlags := nfs.FlagSet(BoldBlue("Experimental"))
 	// Flags for experimental features
 	experimentalFlags.StringVar(&config.ExperimentalQueryPlan, "experimental-query-plan", "", "if non-empty, the version of the experimental query plan to use: `check` or empty")
-	if err := experimentalFlags.MarkHidden("experimental-query-plan"); err != nil {
-		return fmt.Errorf("failed to mark flag as hidden: %w", err)
-	}
 	experimentalFlags.StringVar(&config.ExperimentalLookupResourcesVersion, "experimental-lookup-resources-version", "", "if non-empty, the version of the experimental lookup resources API to use: `lr3` or empty")
 	experimentalFlags.BoolVar(&config.EnableRelationshipExpiration, "enable-experimental-relationship-expiration", true, "enables experimental support for relationship expiration")
 	if err := experimentalFlags.MarkHidden("enable-experimental-relationship-expiration"); err != nil {