Skip to content

Commit 4de5ebf

Browse files
committed
chore: enable QP consistency LR/LS tests unconditionally
1 parent 03a3a18 commit 4de5ebf

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

internal/services/integrationtesting/query_plan_consistency_test.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package integrationtesting_test
55
import (
66
"fmt"
77
"maps"
8-
"os"
98
"path/filepath"
109
"slices"
1110
"testing"
@@ -76,16 +75,10 @@ func runQueryPlanConsistencyForFile(t *testing.T, filePath string) {
7675
runQueryPlanAssertions(t, handle)
7776

7877
t.Run("lookup_resources", func(t *testing.T) {
79-
if os.Getenv("TEST_QUERY_PLAN_RESOURCES") == "" {
80-
t.Skip("Skipping IterResources tests: set TEST_QUERY_PLAN_RESOURCES=true to enable")
81-
}
8278
runQueryPlanLookupResources(t, handle)
8379
})
8480

8581
t.Run("lookup_subjects", func(t *testing.T) {
86-
if os.Getenv("TEST_QUERY_PLAN_SUBJECTS") == "" {
87-
t.Skip("Skipping IterSubjects tests: set TEST_QUERY_PLAN_SUBJECTS=true to enable")
88-
}
8982
runQueryPlanLookupSubjects(t, handle)
9083
})
9184
}
@@ -319,11 +312,6 @@ func testQueryPlanForEachResourceType(
319312

320313
// TestAccessibilitySetMethods tests the various methods of the AccessibilitySet
321314
// to ensure they work correctly and provide code coverage.
322-
//
323-
// NOTE: This test exists to provide coverage for AccessibilitySet methods
324-
// that are otherwise only exercised when TEST_QUERY_PLAN_RESOURCES or TEST_QUERY_PLAN_SUBJECTS
325-
// environment flags are set. This test should be removed when those flags are removed and
326-
// the corresponding tests run unconditionally.
327315
func TestAccessibilitySetMethods(t *testing.T) {
328316
t.Parallel()
329317
require := require.New(t)

0 commit comments

Comments
 (0)