chore(integrationtesting): remove t.Parallel test calls

Author: barakmich

internal/services/integrationtesting/consistency_datastore_test.go

@@ -40,7 +40,6 @@ func TestConsistencyPerDatastore(t *testing.T) {
 		t.Run(engineID, func(t *testing.T) {
 			// FIXME errors arise if spanner is run in parallel
 			if engineID != "spanner" {
-				t.Parallel()
 			}
 			for _, filePath := range consistencyTestFiles {
 				rde := testdatastore.RunDatastoreEngine(t, engineID)

internal/services/integrationtesting/consistency_test.go

@@ -45,20 +45,17 @@ const testTimedelta = 1 * time.Second
 // both real-world schemas, as well as the full set of hand-constructed corner
 // cases so that the system can be fully exercised.
 func TestConsistency(t *testing.T) {
-	t.Parallel()
 
 	// List all the defined consistency test files.
 	consistencyTestFiles, err := consistencytestutil.ListTestConfigs()
 	require.NoError(t, err)
 
 	for _, filePath := range consistencyTestFiles {
 		t.Run(path.Base(filePath), func(t *testing.T) {
-			t.Parallel()
 			for _, dispatcherKind := range []string{"local", "caching"} {
 				t.Run(dispatcherKind, func(t *testing.T) {
 					for _, chunkSize := range []uint16{5, 10} {
 						t.Run(fmt.Sprintf("chunk-size-%d", chunkSize), func(t *testing.T) {
-							t.Parallel()
 							runConsistencyTestSuiteForFile(t, filePath, dispatcherKind == "caching", chunkSize)
 						})
 					}

internal/services/integrationtesting/ops_test.go

@@ -120,7 +120,6 @@ func (dr deleteCaveatedRelationship) Execute(tester opsTester) error {
 }
 
 func TestSchemaAndRelationshipsOperations(t *testing.T) {
-	t.Parallel()
 
 	tcs := []schemaTestCase{
 		// Test: write a basic, valid schema.
@@ -752,7 +751,6 @@ func TestSchemaAndRelationshipsOperations(t *testing.T) {
 
 	for _, tc := range tcs {
 		t.Run(tc.name, func(t *testing.T) {
-			t.Parallel()
 			for _, testerName := range []string{"v1"} {
 				t.Run(testerName, func(t *testing.T) {
 					conn, cleanup, _, _ := testserver.NewTestServer(require.New(t), 0, memdb.DisableGC, false, tf.EmptyDatastore)

internal/services/integrationtesting/query_plan_consistency_test.go

@@ -29,7 +29,6 @@ import (
 )
 
 func TestQueryPlanConsistency(t *testing.T) { // nolint:tparallel
-	t.Parallel()
 	consistencyTestFiles, err := consistencytestutil.ListTestConfigs()
 	require.NoError(t, err)
 	for _, filePath := range consistencyTestFiles {
@@ -195,7 +194,6 @@ func runQueryPlanLookupResources(t *testing.T, handle *queryPlanConsistencyHandl
 	// that are accessible to the subject.
 	testQueryPlanForEachResourceType(t, handle.populated, "validate_lookup_resources",
 		func(t *testing.T, resourceRelation tuple.RelationReference) {
-			t.Parallel()
 			for _, subject := range accessibilitySet.AllSubjectsNoWildcards() {
 				t.Run(tuple.StringONR(subject), func(t *testing.T) {
 					accessibleResources := accessibilitySet.LookupAccessibleResources(resourceRelation, subject)
@@ -245,7 +243,6 @@ func runQueryPlanLookupSubjects(t *testing.T, handle *queryPlanConsistencyHandle
 	// that have access to the resource.
 	testQueryPlanForEachResourceType(t, handle.populated, "validate_lookup_subjects",
 		func(t *testing.T, resourceRelation tuple.RelationReference) {
-			t.Parallel()
 			for _, resource := range accessibilitySet.AllResourcesNoWildcards() {
 				// Only test resources that match the current resource type
 				if resource.ObjectType != resourceRelation.ObjectType || resource.Relation != resourceRelation.Relation {
@@ -323,7 +320,6 @@ func testQueryPlanForEachResourceType(
 // environment flags are set. This test should be removed when those flags are removed and
 // the corresponding tests run unconditionally.
 func TestAccessibilitySetMethods(t *testing.T) {
-	t.Parallel()
 	require := require.New(t)
 
 	ds, err := dsfortesting.NewMemDBDatastoreForTesting(t, 0, testTimedelta, memdb.DisableGC)