Skip to content

Commit cf1ba27

Browse files
committed
fix: ConcurrentRevisionWatch for postgres
1 parent 8773dd7 commit cf1ba27

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

internal/datastore/crdb/watch.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ func (cds *crdbDatastore) DefaultsWatchOptions() datastore.WatchOptions {
7474
WatchBufferLength: 128,
7575
WatchBufferWriteTimeout: 1 * time.Second,
7676
WatchConnectTimeout: 1 * time.Second,
77-
MaximumBufferedChangesByteSize: 1024,
77+
MaximumBufferedChangesByteSize: 0, // 0 means no limit
7878
}
7979
}
8080

internal/datastore/mysql/watch.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func (mds *mysqlDatastore) DefaultsWatchOptions() datastore.WatchOptions {
2121
return datastore.WatchOptions{
2222
WatchBufferLength: defaultWatchBufferLength,
2323
WatchBufferWriteTimeout: defaultWatchBufferWriteTimeout,
24-
MaximumBufferedChangesByteSize: 1204,
24+
MaximumBufferedChangesByteSize: 0, // 0 means no limit
2525
// MySQL does not use CheckpointInterval or WatchConnectTimeout
2626
// MySQL does not support EmitImmediatelyStrategy or WatchSchema
2727
}

internal/datastore/postgres/watch.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func (pgd *pgDatastore) DefaultsWatchOptions() datastore.WatchOptions {
2929
CheckpointInterval: minimumWatchSleep,
3030
WatchBufferLength: defaultWatchBufferLength,
3131
WatchBufferWriteTimeout: defaultWatchBufferWriteTimeout,
32-
MaximumBufferedChangesByteSize: 1024,
32+
MaximumBufferedChangesByteSize: 0, // 0 means no limit
3333
// Postgres does not use WatchConnectTimeout
3434
// Postgres does not support EmitImmediatelyStrategy
3535
}

internal/datastore/spanner/watch.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (sd *spannerDatastore) DefaultsWatchOptions() datastore.WatchOptions {
5858
CheckpointInterval: 100 * time.Millisecond,
5959
WatchBufferLength: defaultWatchBufferLength,
6060
WatchBufferWriteTimeout: defaultWatchBufferWriteTimeout,
61-
MaximumBufferedChangesByteSize: 1024,
61+
MaximumBufferedChangesByteSize: 0, // 0 means no limit
6262
// Spanner does not use WatchConnectTimeout
6363
// Spanner does not support EmitImmediatelyStrategy
6464
}

0 commit comments

Comments
 (0)