chore: update TODOs - ERROR_REASON_DATASTORE_NOT_MIGRATED merged in api, pending authzed-go release

ivanauth · ivanauth · commit d873dd49a52f · 2026-01-07T11:53:41.000-05:00
diff --git a/internal/datastore/common/errors.go b/internal/datastore/common/errors.go
@@ -184,7 +184,7 @@ type SchemaNotInitializedError struct {
 }
 
 func (err SchemaNotInitializedError) GRPCStatus() *status.Status {
-	// TODO: Update to use ERROR_REASON_DATASTORE_NOT_MIGRATED once authzed/api#159 is merged
+	// TODO: Use ERROR_REASON_DATASTORE_NOT_MIGRATED once authzed-go is updated (authzed/api#159 merged)
 	return spiceerrors.WithCodeAndDetails(
 		err,
 		codes.FailedPrecondition,
diff --git a/pkg/middleware/readiness/readiness.go b/pkg/middleware/readiness/readiness.go
@@ -140,8 +140,7 @@ func isMigrationIssue(msg string) bool {
 }
 
 // formatNotReadyError creates a user-friendly error message for migration issues.
-// TODO(authzed/api#159): Once ERROR_REASON_DATASTORE_NOT_MIGRATED is available in the API,
-// use spiceerrors.WithCodeAndReason to include the structured error reason.
+// TODO: Use ERROR_REASON_DATASTORE_NOT_MIGRATED once authzed-go is updated (authzed/api#159 merged)
 func formatNotReadyError(msg string) error {
 	return status.Errorf(codes.FailedPrecondition,
 		"SpiceDB datastore is not migrated. Please run 'spicedb datastore migrate'. Details: %s", msg)

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ type SchemaNotInitializedError struct {`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`func (err SchemaNotInitializedError) GRPCStatus() *status.Status {`
`187`		`- // TODO: Update to use ERROR_REASON_DATASTORE_NOT_MIGRATED once authzed/api#159 is merged`
	`187`	`+ // TODO: Use ERROR_REASON_DATASTORE_NOT_MIGRATED once authzed-go is updated (authzed/api#159 merged)`
`188`	`188`	`return spiceerrors.WithCodeAndDetails(`
`189`	`189`	`err,`
`190`	`190`	`codes.FailedPrecondition,`
Original file line number	Diff line number	Diff line change
`@@ -140,8 +140,7 @@ func isMigrationIssue(msg string) bool {`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`// formatNotReadyError creates a user-friendly error message for migration issues.`
`143`		`-// TODO(authzed/api#159): Once ERROR_REASON_DATASTORE_NOT_MIGRATED is available in the API,`
`144`		`-// use spiceerrors.WithCodeAndReason to include the structured error reason.`
	`143`	`+// TODO: Use ERROR_REASON_DATASTORE_NOT_MIGRATED once authzed-go is updated (authzed/api#159 merged)`
`145`	`144`	`func formatNotReadyError(msg string) error {`
`146`	`145`	`return status.Errorf(codes.FailedPrecondition,`
`147`	`146`	`"SpiceDB datastore is not migrated. Please run 'spicedb datastore migrate'. Details: %s", msg)`