test: add tests for health check service (#2468)

Author: ecordell

internal/services/health/health.go

@@ -105,6 +105,7 @@ func (hm *healthManager) checkIsReady(ctx context.Context) bool {
 	dsReady, err := hm.dsc.ReadyState(ctx)
 	if err != nil {
 		log.Ctx(ctx).Warn().Err(err).Msg("could not check if the datastore was ready")
+		return false
 	}
 
 	if !dsReady.IsReady {

internal/services/health/health_test.go

@@ -0,0 +1,117 @@
+package health
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	"go.uber.org/mock/gomock"
+
+	"github.com/authzed/spicedb/internal/dispatch"
+	dispatchmocks "github.com/authzed/spicedb/internal/dispatch/mocks"
+	"github.com/authzed/spicedb/pkg/datastore"
+	datastoremocks "github.com/authzed/spicedb/pkg/datastore/mocks"
+)
+
+func TestNewHealthManager(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	dispatcher := dispatchmocks.NewMockDispatcher(ctrl)
+	dsc := datastoremocks.NewMockDatastore(ctrl)
+
+	manager := NewHealthManager(dispatcher, dsc)
+
+	require.NotNil(t, manager)
+	require.NotNil(t, manager.HealthSvc())
+}
+
+func TestHealthManagerRegisterReportedService(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	dispatcher := dispatchmocks.NewMockDispatcher(ctrl)
+	dsc := datastoremocks.NewMockDatastore(ctrl)
+	manager := NewHealthManager(dispatcher, dsc)
+
+	serviceName := "test-service"
+	manager.RegisterReportedService(serviceName)
+
+	// Verify service was registered by checking the internal map
+	hm := manager.(*healthManager)
+	_, exists := hm.serviceNames[serviceName]
+	require.True(t, exists)
+}
+
+func TestHealthManagerCheckIsReady(t *testing.T) {
+	testCases := []struct {
+		name            string
+		datastoreReady  bool
+		datastoreError  error
+		dispatcherReady bool
+		expectedResult  bool
+	}{
+		{
+			name:            "both ready",
+			datastoreReady:  true,
+			datastoreError:  nil,
+			dispatcherReady: true,
+			expectedResult:  true,
+		},
+		{
+			name:            "datastore not ready",
+			datastoreReady:  false,
+			datastoreError:  nil,
+			dispatcherReady: true,
+			expectedResult:  false,
+		},
+		{
+			name:            "dispatcher not ready",
+			datastoreReady:  true,
+			datastoreError:  nil,
+			dispatcherReady: false,
+			expectedResult:  false,
+		},
+		{
+			name:            "both not ready",
+			datastoreReady:  false,
+			datastoreError:  nil,
+			dispatcherReady: false,
+			expectedResult:  false,
+		},
+		{
+			name:            "datastore error dispatcher ready",
+			datastoreReady:  false, // doesn't matter when there's an error
+			datastoreError:  errors.New("datastore error"),
+			dispatcherReady: true,
+			expectedResult:  false,
+		},
+		{
+			name:            "datastore error dispatcher not ready",
+			datastoreReady:  false, // doesn't matter when there's an error
+			datastoreError:  errors.New("datastore error"),
+			dispatcherReady: false,
+			expectedResult:  false,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			ctrl := gomock.NewController(t)
+			defer ctrl.Finish()
+
+			dispatcher := dispatchmocks.NewMockDispatcher(ctrl)
+			dispatcher.EXPECT().ReadyState().Return(dispatch.ReadyState{IsReady: tc.dispatcherReady}).MaxTimes(1)
+
+			dsc := datastoremocks.NewMockDatastore(ctrl)
+			dsc.EXPECT().ReadyState(gomock.Any()).Return(datastore.ReadyState{IsReady: tc.datastoreReady}, tc.datastoreError).Times(1)
+
+			hm := &healthManager{
+				dispatcher: dispatcher,
+				dsc:        dsc,
+			}
+
+			require.Equal(t, tc.expectedResult, hm.checkIsReady(t.Context()))
+		})
+	}
+}