Skip to content

Conversation

@tianyuanzoe
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. fetch sample dataset from S3
  2. change min time_limit to 3mins

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tianyuanzoe tianyuanzoe marked this pull request as ready for review November 18, 2024 05:17
@tianyuanzoe tianyuanzoe requested a review from boranhan November 18, 2024 05:18
local_path.write_bytes(response.content)
return dataset_dir
"""Download dataset from S3 to local directory"""
if not os.path.exists(EXTRACT_DIR):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if an empty directory exists? Can we check for all the files as before?

Copy link
Contributor Author

@tianyuanzoe tianyuanzoe Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we don't have the previous os.mkdir() logic here, we will download the zip file from the s3 and extract it, and I have added exception handler in 1. file download phase 2. zip file extraction phase

@tianyuanzoe
Copy link
Contributor Author

Note: This PR is not ready, still need to update

🎉🎉Task completed successfully! If you found this useful, please consider:
⭐ [Starring our repository](https://github.com/autogluon/autogluon-assistant)
"""
S3_URL = "https://automl-mm-bench.s3.us-east-1.amazonaws.com/aga/data/aga_sample_data.zip"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the link to our two sample datasets.

@boranhan boranhan merged commit 323c576 into autogluon:main Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants