MCP and WebUI #218
MCP and WebUI #218
Conversation
latest change
FANGAreNotGnu
left a comment
FANGAreNotGnu
left a comment
There was a problem hiding this comment.
Left some comments for the backend logics, will go through webui and mcp changes later today
docs/tutorials/getting_started.md
Outdated
|
|
||
| ```bash | ||
| mlzero -i INPUT_DATA_FOLDER [-o OUTPUT_DIR] [-c CONFIG_PATH] [-n MAX_ITERATIONS] [--need-user-input] [-u INITIAL_USER_INPUT] [-e EXTRACT_TO] [-v VERBOSITY_LEVEL] | ||
| mlzero -i INPUT_DATA_FOLDER [-o OUTPUT_DIR] [-c CONFIG_PATH] [-n MAX_ITERATIONS] [--ENABLE-PER-ITERATION-INSTRUCTION] [--INITIAL-INSTRUCTION] [-e EXTRACT_TO] [-v VERBOSITY_LEVEL] |
There was a problem hiding this comment.
add an abbreviation for --INITIAL-INSTRUCTION, e.g. -t
src/autogluon/assistant/cli/app.py
Outdated
| need_user_input: bool = typer.Option( | ||
| False, | ||
| "--enable-per-iteration-instruction", | ||
| help="If enabled, you can provide a prompt for the next iteration at each iteration", |
There was a problem hiding this comment.
If enabled, provide an instruction at the start of each iteration (except the first, which uses the initial instruction). The process suspends until you provide it.
src/autogluon/assistant/cli/app.py
Outdated
| from pathlib import Path # noqa: E402 | ||
|
|
||
| import typer # noqa: E402 |
There was a problem hiding this comment.
Move it to the correct place?
src/autogluon/assistant/cli/app.py
Outdated
| from .. import __file__ as assistant_file # noqa: E402 | ||
|
|
||
| PACKAGE_ROOT = Path(assistant_file).parent |
There was a problem hiding this comment.
Any reason not to write as Path(__file__).parent.parent?
| from omegaconf import OmegaConf | ||
|
|
||
| from .managers import Manager | ||
| # from .managers import Manager |
There was a problem hiding this comment.
Delete the code instead of commenting out
| """Cleanup method to properly close the embedding model.""" | ||
| self.cleanup() | ||
|
|
||
| def __log_wrapper(self, input): |
There was a problem hiding this comment.
Use a better name, e.g. _silent_encode
FANGAreNotGnu
left a comment
FANGAreNotGnu
left a comment
There was a problem hiding this comment.
Had two minor comments to fix. Also let's discuss offline about the position of the mcp folder
.gitignore
Outdated
| *.credentials | ||
| *.creds | ||
| credentials.txt | ||
| aws_credentials.txt No newline at end of file |
| run_agent( | ||
| input_data_folder=<your-input-folder>, | ||
| output_folder=<your-output-folder> | ||
| ) |
There was a problem hiding this comment.
add a commented line:
run_agent(
input_data_folder=<your-input-folder>,
output_folder=<your-output-folder>,
# more args ...
)
|
Also it seems only |
FANGAreNotGnu
left a comment
FANGAreNotGnu
left a comment
There was a problem hiding this comment.
LGTM. We should add more unit/integrated tests in the following PRs.
2 participants
Description
How Has This Been Tested?
pytest tests/)MCP, job queue: manually tested
Configuration Changes
default.yaml. Please describe the changes:Type of Change