Skip to content

Commit 1923ff1

Browse files
committed
Update display_name logic
1 parent 8a2d28f commit 1923ff1

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

tabarena/tabarena/nips2025_utils/artifacts/method_metadata.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def __init__(
6565
model_key = ag_key
6666
self.model_key = model_key
6767
self.name = name
68-
self.display_name = display_name
6968
self.name_suffix = name_suffix
7069
self.config_default = config_default
7170
self.compute = compute
@@ -81,6 +80,7 @@ def __init__(
8180
self.s3_bucket = s3_bucket
8281
self.s3_prefix = s3_prefix
8382
self.upload_as_public = upload_as_public
83+
self.reference_url = reference_url
8484

8585
assert isinstance(self.method, str) and len(self.method) > 0
8686
assert isinstance(self.artifact_name, str) and len(self.artifact_name) > 0
@@ -90,16 +90,21 @@ def __init__(
9090
raise AssertionError(f"Cannot specify `name` for method_type: 'config'.")
9191
if self.name is not None and self.name_suffix is not None:
9292
raise AssertionError(f"Must only specify one of `name` and `name_suffix`.")
93-
self.reference_url = reference_url
9493

95-
def get_display_name(self) -> str:
96-
if self.display_name is not None:
97-
return self.display_name
94+
if display_name is None:
95+
display_name = self._compute_display_name()
96+
self.display_name = display_name
97+
98+
assert isinstance(self.display_name, str) and len(self.display_name) > 0
99+
100+
def _compute_display_name(self) -> str:
98101
if self.name is not None:
99-
return self.name
100-
if self.config_type is not None:
101-
return self.config_type
102-
return self.method
102+
display_name = self.name
103+
elif self.config_type is not None:
104+
display_name = self.config_type
105+
else:
106+
display_name = self.method
107+
return display_name
103108

104109
@property
105110
def config_type(self) -> str | None:

tabarena/tabarena/nips2025_utils/compare.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def compare_on_tabarena(
3939
method_metadatas = tabarena_context.method_metadata_collection.method_metadata_lst
4040
for m in method_metadatas:
4141
if m.method_type == "config":
42-
display_name = m.get_display_name()
42+
display_name = m.display_name
4343
if display_name is not None:
4444
if m.config_type in method_rename_map:
4545
print(

0 commit comments

Comments
 (0)