replace PharData with tar command to prevent memory exhaustion

Author: Julien Jacottet

src/Automate/Archiver.php

@@ -13,7 +13,8 @@
 
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Filesystem\Path;
-use Symfony\Component\Finder\Finder;
+use Symfony\Component\Process\Exception\ProcessFailedException;
+use Symfony\Component\Process\Process;
 
 use function Symfony\Component\String\u;
 
@@ -31,29 +32,34 @@ public function __construct()
     /**
      * @param string[] $exclude
      */
-    public function archive(string $path, array $exclude = []): \PharData
+    public function archive(string $path, array $exclude = []): string
     {
         $this->clear($path);
 
-        $archive = new \PharData($this->getArchiveFileName($path, false));
+        $archiveFile = $this->getArchiveFileName($path);
         $cwd = getcwd();
 
-        if (is_dir($path)) {
-            $finder = new Finder();
-            $finder->files()
-                ->ignoreDotFiles(false)
-                ->in($path)
-                ->notPath($exclude);
+        // Build tar command
+        $command = ['tar', '-czf', $archiveFile];
 
-            $archive->buildFromIterator($finder->getIterator(), $cwd);
-        } else {
-            $archive->addFile($path, Path::makeRelative($path, $cwd));
+        // Add exclusions
+        foreach ($exclude as $pattern) {
+            $command[] = '--exclude='.$pattern;
         }
 
-        /** @var \PharData $compressed */
-        $compressed = $archive->compress(\Phar::GZ);
+        // Add the path to archive (relative to cwd)
+        $relativePath = Path::makeRelative($path, $cwd);
+        $command[] = $relativePath;
 
-        return $compressed;
+        // Execute tar command
+        $process = new Process($command, $cwd);
+        $process->run();
+
+        if (!$process->isSuccessful()) {
+            throw new ProcessFailedException($process);
+        }
+
+        return $archiveFile;
     }
 
     public function getArchiveFileName(string $path, bool $compressed = true): string

src/Automate/Workflow/Context.php

@@ -134,13 +134,13 @@ public function upload(string $path, ?array $exclude, ?array $serversList = null
         }
 
         $this->logger->info('    Upload preparation ...');
-        $archive = $this->archiver->archive($path, $exclude);
+        $archiveFile = $this->archiver->archive($path, $exclude);
         $archiveFileName = $this->archiver->getArchiveFileName($path);
 
         $this->logger->info('    Send data ...');
-        $this->exec(static function (Session $session) use ($archive, $archiveFileName): void {
+        $this->exec(static function (Session $session) use ($archiveFile, $archiveFileName): void {
             $targetPath = Path::join($session->getReleasePath(), $archiveFileName);
-            $session->upload($archive->getPath(), $targetPath);
+            $session->upload($archiveFile, $targetPath);
         }, $serversList);
 
         $this->logger->info('    Untar data...');

tests/Automate/ArchiverTest.php

@@ -31,8 +31,13 @@ protected function tearDown(): void
 
     public function testArchive(): void
     {
-        $phar = $this->archiver->archive(self::PATH);
+        $archiveFile = $this->archiver->archive(self::PATH);
 
+        // Verify the archive file was created
+        $this->assertFileExists($archiveFile);
+
+        // Open and verify archive contents
+        $phar = new \PharData($archiveFile);
         $this->assertTrue($phar->offsetExists('tests/fixtures/folder/a.txt'));
         $this->assertTrue($phar->offsetExists('tests/fixtures/folder/sub/b.txt'));
         $this->assertTrue($phar->offsetExists('tests/fixtures/folder/.sub/c.txt'));