get error message if objectives are unequal

Author: KrissiHub

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Plugins
 - Add symbolic explanations plugin (#46).
 - It is now possible to view multiple unequal runs at once in Cost over Time and Pareto (#93).
+- Runs with unequal objectives cannot be displayed together.
 - Added an enum for displaying according warning messages.
 
 ## Enhancements

deepcave/plugins/objective/cost_over_time.py

@@ -87,7 +87,7 @@ def check_runs_compatibility(self, runs: List[AbstractRun]) -> None:
             elif run_inequality == RunInequality.INEQ_META:
                 notification.update("The meta data of the runs is not equal.", color="warning")
             elif run_inequality == RunInequality.INEQ_OBJECTIVE:
-                notification.update("The objectives of the runs are not equal.", color="warning")
+                raise NotMergeableError("The objectives of the selected runs cannot be merged.")
 
         # Set some attributes here
         # It is necessary to get the run with the smallest budget and objective options

deepcave/plugins/objective/pareto_front.py

@@ -86,7 +86,7 @@ def check_runs_compatibility(self, runs: List[AbstractRun]) -> None:
             elif run_inequality == RunInequality.INEQ_META:
                 notification.update("The meta data of the runs is not equal.", color="warning")
             elif run_inequality == RunInequality.INEQ_OBJECTIVE:
-                notification.update("The objectives of the runs are not equal.", color="warning")
+                raise NotMergeableError("The objectives of the selected runs cannot be merged.")
 
         # Set some attributes here
         # It is necessary to get the run with the smallest budget and objective options

deepcave/runs/__init__.py

@@ -1236,25 +1236,46 @@ def check_equality(
     if len(runs) == 0:
         return result
 
-    # Check meta
-    if meta:
-        ignore = ["objectives", "budgets", "wallclock_limit"]
-
-        m1 = runs[0].get_meta()
+    # Check if objectives are mergeable
+    if objectives:
+        o1 = None
         for run in runs:
-            m2 = run.get_meta()
+            o2 = run.get_objectives()
 
-            for k, v in m1.items():
-                # Don't check on objectives or budgets
-                if k in ignore:
-                    continue
+            if o1 is None:
+                o1 = o2
+                continue
 
-                if k not in m2 or m2[k] != v:
+            if len(o1) != len(o2):
+                raise NotMergeableError(
+                    "Objectives of runs are not equal.", RunInequality.INEQ_OBJECTIVE
+                )
+
+            for o1_, o2_ in zip(o1, o2):
+                try:
+                    o1_.merge(o2_)
+                except NotMergeableError:
                     raise NotMergeableError(
-                        "Meta data of runs are not equal.", RunInequality.INEQ_META
+                        "Objectives of runs are not equal.", RunInequality.INEQ_OBJECTIVE
                     )
 
-        result["meta"] = m1
+        assert o1 is not None
+        serialized_objectives = [o.to_json() for o in o1]
+        result["objectives"] = serialized_objectives
+        if meta:
+            result["meta"]["objectives"] = serialized_objectives
+
+    # Also check if budgets are the same
+    if budgets:
+        b1 = runs[0].get_budgets(include_combined=False)
+        for run in runs:
+            b2 = run.get_budgets(include_combined=False)
+            if b1 != b2:
+                raise NotMergeableError("Budgets of runs are not equal.", RunInequality.INEQ_BUDGET)
+
+        result["budgets"] = b1
+        if meta:
+            result["meta"]["budgets"] = b1
 
     # Make sure the same configspace is used
     # Otherwise it does not make sense to merge
@@ -1270,40 +1291,24 @@ def check_equality(
 
         result["configspace"] = cs1
 
-    # Also check if budgets are the same
-    if budgets:
-        b1 = runs[0].get_budgets(include_combined=False)
-        for run in runs:
-            b2 = run.get_budgets(include_combined=False)
-            if b1 != b2:
-                raise NotMergeableError("Budgets of runs are not equal.", RunInequality.INEQ_BUDGET)
-
-        result["budgets"] = b1
-        if meta:
-            result["meta"]["budgets"] = b1
+    # Check meta
+    if meta:
+        ignore = ["objectives", "budgets", "wallclock_limit"]
 
-    # And if objectives are the same
-    if objectives:
-        o1 = None
+        m1 = runs[0].get_meta()
         for run in runs:
-            o2 = run.get_objectives()
-
-            if o1 is None:
-                o1 = o2
-                continue
+            m2 = run.get_meta()
 
-            if len(o1) != len(o2):
-                raise NotMergeableError(
-                    "Objectives of runs are not equal.", RunInequality.INEQ_OBJECTIVE
-                )
+            for k, v in m1.items():
+                # Don't check on objectives or budgets
+                if k in ignore:
+                    continue
 
-            for o1_, o2_ in zip(o1, o2):
-                o1_.merge(o2_)
+                if k not in m2 or m2[k] != v:
+                    raise NotMergeableError(
+                        "Meta data of runs are not equal.", RunInequality.INEQ_META
+                    )
 
-        assert o1 is not None
-        serialized_objectives = [o.to_json() for o in o1]
-        result["objectives"] = serialized_objectives
-        if meta:
-            result["meta"]["objectives"] = serialized_objectives
+        result["meta"] = m1
 
     return result