Fix: review comments

Author: eddiebergman

CONTRIBUTING.md

@@ -46,7 +46,7 @@ Following that we'll tell you about how you can test your changes locally and th
     # If you missed the --recurse-submodules arg during clone or need to install the
     # submodule manually, then execute the following line:
     #
-    # git submodule udate --init --recursive
+    # git submodule update --init --recursive
 
     # ... Alternatively, if you would prefer a more manual method
     # Show all the available branches with a * beside your current one

autosklearn/automl.py

@@ -1928,7 +1928,6 @@ def has_key(rv, key):
             table_dict[model_id]['ensemble_weight'] = weight
 
         table = pd.DataFrame.from_dict(table_dict, orient='index')
-        table.sort_values(by='cost', inplace=True)
 
         # Checking which resampling strategy is chosen and selecting the appropriate models
         is_cv = (self._resampling_strategy == "cv")

autosklearn/metalearning/optimizers/metalearn_optimizer/metalearner.py

@@ -111,7 +111,7 @@ def _learn(self, exclude_double_configurations=True):
                 except KeyError:
                     # TODO should I really except this?
                     self.logger.info("Could not find runs for instance %s" % task_id)
-                    runs[task_id] = pd.Series([], name=task_id, dtype=np.float64)
+                    runs[task_id] = pd.Series([], name=task_id, dtype=float)
 
             runs = pd.DataFrame(runs)
 

doc/releases.rst

@@ -22,7 +22,7 @@ Version 0.14.4
 * Maint #1325: Test workflow can now be manually triggered
 * Maint #1332: Update docstring and typing of ``include`` and ``exclude`` params
 * Add #1260: Support for Python 3.10
-* Add #1318: First update to use the shared backend in ``automl_common``
+* Add #1318: First update to use the shared backend in a new submodule `automl_common <https://github.com/automl/automl_common>`_
 * Fix #1339: Resolve dependancy issues with ``sphinx_toolbox``
 * Fix #1335: Fix issue where some regression algorithm gave incorrect output dimensions as raised in #1297
 * Doc #1340: Update example for predefined splits