Skip to content

Commit 48f5e40

Browse files
committed
fix: dino
1 parent 0d56563 commit 48f5e40

File tree

1 file changed

+5
-26
lines changed

1 file changed

+5
-26
lines changed

app/src/core/api-client.js

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -330,32 +330,11 @@ export class ApiClient {
330330
}
331331

332332
_shouldRetryGroundingDino(serverResponse, userPrompt) {
333-
try {
334-
const p = String(userPrompt || '').trim().toLowerCase();
335-
if (!p) return false;
336-
const mv = String(serverResponse?.model_version || '');
337-
if (/fallback/i.test(mv)) return true;
338-
// Label Studio-like fallback: value.text === 'object' and boxes have zero area
339-
if (Array.isArray(serverResponse?.results)) {
340-
let any = false;
341-
let allZero = true;
342-
let allObject = true;
343-
for (const group of serverResponse.results) {
344-
const arr = Array.isArray(group?.result) ? group.result : [];
345-
for (const item of arr) {
346-
if (item?.type !== 'rectanglelabels') continue;
347-
const v = item?.value || {};
348-
any = true;
349-
const w = Number(v.width || 0);
350-
const h = Number(v.height || 0);
351-
if (w > 0 && h > 0) allZero = false;
352-
const txt = String(v.text || '').trim().toLowerCase();
353-
if (txt !== 'object') allObject = false;
354-
}
355-
}
356-
if (any && (allZero || allObject)) return true;
357-
}
358-
} catch {}
333+
// Previous heuristics were too aggressive and retried JSON even on valid results
334+
// (e.g., model_version containing "fallback" or zero-width boxes from some servers).
335+
// Keep conservative: do not trigger heuristic retries here.
336+
// We already retry JSON on clear client/server errors in callModel.
337+
void serverResponse; void userPrompt;
359338
return false;
360339
}
361340

0 commit comments

Comments
 (0)