fix broken security provider check and test.

Author: autonomousapps

src/functionalTest/groovy/com/autonomousapps/jvm/projects/SecurityProviderProject.groovy

@@ -7,7 +7,6 @@ import com.autonomousapps.kit.GradleProject
 import com.autonomousapps.kit.Source
 import com.autonomousapps.kit.SourceType
 import com.autonomousapps.kit.gradle.Dependency
-import com.autonomousapps.kit.gradle.Plugin
 import com.autonomousapps.model.Advice
 import com.autonomousapps.model.ProjectAdvice
 
@@ -63,11 +62,11 @@ final class SecurityProviderProject extends AbstractProject {
     return actualProjectAdvice(gradleProject)
   }
 
-  private final appAdvice = [
+  private final projAdvice = [
     Advice.ofChange(moduleCoordinates(conscryptUber), conscryptUber.configuration, 'runtimeOnly'),
   ] as Set<Advice>
 
   final Set<ProjectAdvice> expectedBuildHealth = [
-    projectAdviceForDependencies(':proj', appAdvice)
+    projectAdviceForDependencies(':proj', projAdvice)
   ]
 }

src/main/kotlin/com/autonomousapps/internal/ClassNames.kt

@@ -6,7 +6,8 @@ internal object ClassNames {
 
   fun canonicalize(className: String): String = className.replace('/', '.')
 
-  fun isEnum(superClassName: String?): Boolean = superClassName == "java/lang/Enum"
+  // TODO(tsr): I think I can delete the slashy version but I'm not sure
+  fun isEnum(superClassName: String?): Boolean = superClassName == "java/lang/Enum" || superClassName == "java.lang.Enum"
 
-  fun isSecurityProvider(superClassName: String?): Boolean = superClassName == "java/security/Provider"
+  fun isSecurityProvider(superClassName: String?): Boolean = superClassName == "java.security.Provider"
 }