Skip to content

Commit 1b272ef

Browse files
committed
test: remove hardcoded URLs in new_tab
1 parent 0ac63a2 commit 1b272ef

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

tests/test_browser/test_browser_base.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -566,19 +566,18 @@ async def test_multiple_tab_handling(mock_browser):
566566
# Simulate getting multiple tabs
567567
mock_browser._connection_handler.execute_command.side_effect = [
568568
{'result': {'targetId': 'tab1'}},
569-
{'result': {'targetId': 'tab2'}}
569+
{'result': {'targetId': 'tab2'}},
570570
]
571571

572-
tab1 = await mock_browser.new_tab(url='https://example1.com')
573-
tab2 = await mock_browser.new_tab(url='https://example2.com')
572+
tab1 = await mock_browser.new_tab()
573+
tab2 = await mock_browser.new_tab()
574574

575575
assert tab1._target_id == 'tab1'
576576
assert tab2._target_id == 'tab2'
577577

578578
# Verify that correct calls were made
579579
calls = mock_browser._connection_handler.execute_command.call_args_list
580-
assert calls[0][0][0] == TargetCommands.create_target('https://example1.com', None)
581-
assert calls[1][0][0] == TargetCommands.create_target('https://example2.com', None)
580+
assert len(calls) == 2
582581

583582

584583
# New tests for _get_valid_tab_id
@@ -1194,7 +1193,7 @@ async def test_get_opened_tabs_integration_with_new_tab(mock_browser):
11941193
}
11951194

11961195
# Create a new tab
1197-
new_tab = await mock_browser.new_tab('https://example.com')
1196+
new_tab = await mock_browser.new_tab()
11981197
assert new_tab._target_id == 'new_tab_1'
11991198

12001199
# Mock updated targets after tab creation

0 commit comments

Comments
 (0)