tests: add tests for new requests functionality

Author: thalissonvs

tests/test_browser/test_browser_base.py

@@ -20,8 +20,9 @@
 )
 from pydoll.protocol.fetch.events import FetchEvent
 from pydoll.connection.connection_handler import ConnectionHandler
-from pydoll.constants import DownloadBehavior, PermissionType, NetworkErrorReason, RequestMethod
 
+from pydoll.protocol.network.types import RequestMethod, ErrorReason
+from pydoll.protocol.browser.types import DownloadBehavior, PermissionType
 
 class ConcreteBrowser(Browser):
     def _get_default_binary_location(self) -> str:
@@ -488,7 +489,7 @@ async def test_set_download_behavior(mock_browser):
 @pytest.mark.asyncio
 async def test_set_download_path(mock_browser):
     mock_browser._execute_command = AsyncMock()
-    await mock_browser.set_download_path('/downloads')
+    await mock_browser.set_download_path(path='/downloads')
 
     mock_browser._execute_command.assert_called_with(
         BrowserCommands.set_download_behavior(
@@ -716,7 +717,7 @@ async def test_continue_request_with_all_params(mock_browser):
 async def test_fail_request(mock_browser):
     """Test fail_request."""
     request_id = 'test_request_123'
-    error_reason = NetworkErrorReason.FAILED
+    error_reason = ErrorReason.FAILED
 
     await mock_browser.fail_request(request_id, error_reason)
 

tests/test_browser/test_browser_tab.py

@@ -5,7 +5,9 @@
 from unittest.mock import AsyncMock, MagicMock, patch, ANY
 from pathlib import Path
 
-from pydoll.constants import By, RequestStage, ResourceType, RequestMethod
+from pydoll.protocol.network.types import ResourceType, RequestMethod
+from pydoll.protocol.fetch.types import RequestStage
+from pydoll.constants import By
 from pydoll.browser.tab import Tab
 from pydoll.exceptions import (
     NoDialogPresent,
@@ -809,14 +811,13 @@ async def test_expect_file_chooser_with_path_objects(self, tab):
     @pytest.mark.asyncio
     async def test_expect_file_chooser_event_handler_single_file(self, tab):
         """Test the real event_handler function with single file."""
-        from pydoll.protocol.dom.types import EventFileChooserOpened
-        from pydoll.protocol.page.events import PageEvent
+        from pydoll.protocol.page.events import FileChooserOpenedEvent, PageEvent
 
         # Mock execute_command to capture the call
         tab._execute_command = AsyncMock()
 
         # Create mock event data
-        mock_event: EventFileChooserOpened = {
+        mock_event: FileChooserOpenedEvent = {
             'method': 'Page.fileChooserOpened',
             'params': {
                 'frameId': 'test-frame-id',
@@ -855,14 +856,13 @@ async def mock_on(event_name, handler, temporary=False):
     @pytest.mark.asyncio
     async def test_expect_file_chooser_event_handler_multiple_files(self, tab):
         """Test the real event_handler function with multiple files."""
-        from pydoll.protocol.dom.types import EventFileChooserOpened
-        from pydoll.protocol.page.events import PageEvent
+        from pydoll.protocol.page.events import FileChooserOpenedEvent, PageEvent
 
         # Mock execute_command to capture the call
         tab._execute_command = AsyncMock()
 
         # Create mock event data
-        mock_event: EventFileChooserOpened = {
+        mock_event: FileChooserOpenedEvent = {
             'method': 'Page.fileChooserOpened',
             'params': {
                 'frameId': 'test-frame-id',
@@ -900,14 +900,13 @@ async def mock_on(event_name, handler, temporary=False):
 
     async def _test_event_handler_with_files(self, tab, files, expected_files, backend_node_id):
         """Helper method to test event handler with different file types."""
-        from pydoll.protocol.dom.types import EventFileChooserOpened
-        from pydoll.protocol.page.events import PageEvent
+        from pydoll.protocol.page.events import FileChooserOpenedEvent, PageEvent
 
         # Mock execute_command to capture the call
         tab._execute_command = AsyncMock()
 
         # Create mock event data
-        mock_event: EventFileChooserOpened = {
+        mock_event: FileChooserOpenedEvent = {
             'method': 'Page.fileChooserOpened',
             'params': {
                 'frameId': 'test-frame-id',
@@ -1241,10 +1240,10 @@ async def test_continue_request(self, tab):
     @pytest.mark.asyncio
     async def test_fail_request(self, tab):
         """Test fail_request method."""
-        from pydoll.constants import NetworkErrorReason
+        from pydoll.protocol.network.types import ErrorReason
 
         request_id = 'test_request_456'
-        error_reason = NetworkErrorReason.FAILED
+        error_reason = ErrorReason.FAILED
 
         await tab.fail_request(request_id, error_reason)
 
@@ -1288,7 +1287,7 @@ async def test_fulfill_request(self, tab):
     @pytest.mark.asyncio
     async def test_continue_request_with_all_params(self, tab):
         """Test continue_request with all parameters."""
-        from pydoll.constants import RequestMethod
+        from pydoll.protocol.network.types import RequestMethod
 
         request_id = 'test_request_456'
         url = 'https://modified-example.com'
@@ -1339,10 +1338,10 @@ async def test_continue_request_with_different_id(self, tab):
     @pytest.mark.asyncio
     async def test_fail_request_with_different_error(self, tab):
         """Test fail_request with different error reason."""
-        from pydoll.constants import NetworkErrorReason
+        from pydoll.protocol.network.types import ErrorReason
 
         request_id = 'test_request_error'
-        error_reason = NetworkErrorReason.ABORTED
+        error_reason = ErrorReason.ABORTED
 
         await tab.fail_request(request_id, error_reason)