test: add tests for proxy handling and context auth storage in browser

Author: thalissonvs

tests/test_browser/test_browser_base.py

@@ -539,6 +539,130 @@ async def test_create_browser_context(mock_browser):
     )
 
 
+@pytest.mark.asyncio
+async def test_create_browser_context_with_private_proxy_sanitizes_and_stores_auth(mock_browser):
+    mock_browser._execute_command = AsyncMock()
+    mock_browser._execute_command.return_value = {'result': {'browserContextId': 'ctx1'}}
+
+    context_id = await mock_browser.create_browser_context(
+        proxy_server='http://user:[email protected]:8080',
+        proxy_bypass_list='localhost',
+    )
+
+    assert context_id == 'ctx1'
+    # Should send sanitized proxy (without credentials) to CDP
+    mock_browser._execute_command.assert_called_with(
+        TargetCommands.create_browser_context(
+            proxy_server='http://proxy.example.com:8080', proxy_bypass_list='localhost'
+        )
+    )
+    # Credentials must be stored per-context for later Tab setup
+    assert mock_browser._context_proxy_auth['ctx1'] == ('user', 'pass')
+
+
+@pytest.mark.asyncio
+async def test_create_browser_context_with_private_proxy_no_scheme_sanitizes_and_stores_auth(
+    mock_browser,
+):
+    mock_browser._execute_command = AsyncMock()
+    mock_browser._execute_command.return_value = {'result': {'browserContextId': 'ctx2'}}
+
+    # Without scheme -> should default to http://
+    context_id = await mock_browser.create_browser_context(
+        proxy_server='user:[email protected]:9000'
+    )
+
+    assert context_id == 'ctx2'
+    mock_browser._execute_command.assert_called_with(
+        TargetCommands.create_browser_context(proxy_server='http://host.local:9000', proxy_bypass_list=None)
+    )
+    assert mock_browser._context_proxy_auth['ctx2'] == ('user', 'pwd')
+
+
+@pytest.mark.parametrize(
+    'input_proxy, expected_sanitized, expected_creds',
+    [
+        ('username:password@host:8080', 'http://host:8080', ('username', 'password')),
+        ('http://username:password@host:8080', 'http://host:8080', ('username', 'password')),
+        ('socks5://user:[email protected]:1080', 'socks5://10.0.0.1:1080', ('user', 'pass')),
+        ('host:3128', 'http://host:3128', None),
+    ],
+)
+def test__sanitize_proxy_and_extract_auth_variants(input_proxy, expected_sanitized, expected_creds):
+    sanitized, creds = Browser._sanitize_proxy_and_extract_auth(input_proxy)
+    assert sanitized == expected_sanitized
+    assert creds == expected_creds
+
+
+@pytest.mark.asyncio
+@patch('pydoll.browser.chromium.base.Tab')
+async def test_new_tab_sets_up_context_proxy_auth_handlers(MockTab, mock_browser):
+    # Arrange context credentials
+    context_id = 'ctx-auth'
+    mock_browser._context_proxy_auth[context_id] = ('u1', 'p1')
+
+    # Mock CDP create_target response
+    mock_browser._connection_handler.execute_command.return_value = {
+        'result': {'targetId': 'new_page_ctx'}
+    }
+
+    # Fake Tab with async methods
+    fake_tab = MagicMock()
+    fake_tab.enable_fetch_events = AsyncMock()
+    fake_tab.on = AsyncMock()
+    MockTab.return_value = fake_tab
+
+    # Act
+    tab = await mock_browser.new_tab(browser_context_id=context_id)
+
+    # Assert: enable fetch events with auth handling
+    fake_tab.enable_fetch_events.assert_awaited_once()
+    enable_call = fake_tab.enable_fetch_events.await_args
+    assert enable_call.kwargs.get('handle_auth') is True
+
+    # Assert: event handlers registered with temporary=True
+    from pydoll.protocol.fetch.events import FetchEvent as FE
+    # First: request paused
+    assert any(
+        (c.args[0] == FE.REQUEST_PAUSED and c.kwargs.get('temporary') is True)
+        for c in fake_tab.on.await_args_list
+    )
+    # Second: auth required
+    auth_calls = [c for c in fake_tab.on.await_args_list if c.args[0] == FE.AUTH_REQUIRED]
+    assert len(auth_calls) == 1
+    cb = auth_calls[0].args[1]
+    from functools import partial as _partial
+    assert isinstance(cb, _partial)
+    assert cb.keywords.get('proxy_username') == 'u1'
+    assert cb.keywords.get('proxy_password') == 'p1'
+    assert cb.keywords.get('tab') is fake_tab
+
+    # Returned tab is the fake
+    assert tab is fake_tab
+
+
+@pytest.mark.asyncio
+@patch('pydoll.browser.chromium.base.Tab')
+async def test_new_tab_without_context_proxy_auth_does_not_setup_handlers(MockTab, mock_browser):
+    # No credentials stored for this context
+    context_id = 'ctx-no-auth'
+    mock_browser._context_proxy_auth.pop(context_id, None)
+
+    mock_browser._connection_handler.execute_command.return_value = {
+        'result': {'targetId': 'new_page2'}
+    }
+
+    fake_tab = MagicMock()
+    fake_tab.enable_fetch_events = AsyncMock()
+    fake_tab.on = AsyncMock()
+    MockTab.return_value = fake_tab
+
+    await mock_browser.new_tab(browser_context_id=context_id)
+
+    fake_tab.enable_fetch_events.assert_not_called()
+    fake_tab.on.assert_not_called()
+
+
 @pytest.mark.asyncio
 async def test_delete_browser_context(mock_browser):
     mock_browser._execute_command = AsyncMock()