Skip to content

Commit ae38618

Browse files
committed
refactor: refactor proxy parsing logic for improved clarity and efficiency
1 parent db92ed1 commit ae38618

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

pydoll/browser/managers/proxy_manager.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,13 @@ def _parse_proxy(proxy_value: str) -> tuple[bool, Optional[str], Optional[str],
7474
return False, None, None, proxy_value
7575

7676
try:
77-
# Split scheme if present
77+
scheme = ''
78+
has_scheme = False
7879
if '://' in proxy_value:
79-
scheme, rest = proxy_value.split('://', 1)
80+
scheme, proxy_value = proxy_value.split('://', 1)
8081
has_scheme = True
81-
else:
82-
rest = proxy_value
83-
scheme = ''
84-
has_scheme = False
8582

86-
creds_part, server_part = rest.split('@', 1)
83+
creds_part, server_part = proxy_value.split('@', 1)
8784
username, password = creds_part.split(':', 1)
8885

8986
clean_proxy = f"{scheme}://{server_part}" if has_scheme else server_part

0 commit comments

Comments
 (0)