Merge pull request #314 from autoscrape-labs/fix/iframe-oofpif

fix iframe empty inner html

Author: thalissonvs

pydoll/elements/web_element.py

@@ -928,17 +928,25 @@ async def _resolve_oopif_by_parent(
             if not attached_session_id:
                 continue
             frame_tree = await self._get_frame_tree_for(browser_handler, attached_session_id)
+            root_frame = (frame_tree or {}).get('frame', {})
+            root_frame_id = root_frame.get('id', '')
+
+            if root_frame_id and backend_node_id is not None:
+                owner_backend_id = await self._owner_backend_for(
+                    self._connection_handler, None, root_frame_id
+                )
+                if owner_backend_id == backend_node_id:
+                    return (
+                        browser_handler,
+                        attached_session_id,
+                        root_frame_id,
+                        root_frame.get('url'),
+                    )
+
             child_frame_id = WebElement._find_child_by_parent(frame_tree, parent_frame_id)
             if child_frame_id:
                 return browser_handler, attached_session_id, child_frame_id, None
-            root_frame_id = (frame_tree or {}).get('frame', {}).get('id', '')
-            if not root_frame_id or backend_node_id is None:
-                continue
-            owner_backend_id = await self._owner_backend_for(
-                self._connection_handler, None, root_frame_id
-            )
-            if owner_backend_id == backend_node_id:
-                return browser_handler, attached_session_id, root_frame_id, None
+
         return None, None, None, None
 
     @staticmethod

tests/test_web_element.py

@@ -2450,7 +2450,11 @@ async def side_effect(command, timeout=60):
 
     @pytest.mark.asyncio
     async def test_resolve_oopif_scan_all_targets_find_child(self, iframe_element):
-        """Test OOPIF resolution by scanning all targets and finding child."""
+        """Test OOPIF resolution by scanning all targets and finding child.
+        
+        This tests the fallback path where the root frame owner doesn't match,
+        so the code falls back to finding a child frame by parentId.
+        """
         with patch('pydoll.elements.web_element.ConnectionHandler') as mock_handler_class:
             browser_handler = AsyncMock()
             browser_handler.execute_command = AsyncMock()
@@ -2498,9 +2502,14 @@ async def side_effect(command, timeout=60):
                             }
                         }
                     }
+                if method == 'DOM.getFrameOwner':
+                    # Return non-matching backend node ID to trigger child fallback
+                    return {'result': {'backendNodeId': 888}}  # Does NOT match 999
                 raise AssertionError(f'Unexpected method {method}')
 
             browser_handler.execute_command.side_effect = side_effect
+            # Mock the connection handler for DOM.getFrameOwner calls
+            iframe_element._connection_handler.execute_command.side_effect = side_effect
 
             handler, session_id, frame_id, url = await iframe_element._resolve_oopif_by_parent(
                 'parent-frame-123', 999
@@ -2509,11 +2518,16 @@ async def side_effect(command, timeout=60):
             assert handler == browser_handler
             assert session_id == 'session-1'
             assert frame_id == 'matching-child'
-            assert url is None  # URL not resolved in this path
+            assert url is None  # URL not resolved in child path
 
     @pytest.mark.asyncio
     async def test_resolve_oopif_scan_all_targets_match_root_owner(self, iframe_element):
-        """Test OOPIF resolution by matching root frame owner."""
+        """Test OOPIF resolution by matching root frame owner.
+        
+        This is the primary path for OOPIF resolution: when the root frame
+        of the OOPIF target is owned by our iframe element (matching backend_node_id).
+        The URL should be returned from the root frame.
+        """
         with patch('pydoll.elements.web_element.ConnectionHandler') as mock_handler_class:
             browser_handler = AsyncMock()
             browser_handler.execute_command = AsyncMock()
@@ -2569,7 +2583,7 @@ async def side_effect(command, timeout=60):
             assert handler == browser_handler
             assert session_id == 'session-1'
             assert frame_id == 'oopif-root'
-            assert url is None
+            assert url == 'https://oopif.com'  # URL is now correctly returned
 
     @pytest.mark.asyncio
     async def test_resolve_oopif_not_found(self, iframe_element):