Fix data race in timeout handler (#339)

yacovm · samliok · web-flow · commit 688ad3faf7b4 · 2026-02-09T14:04:34.000+01:00
Signed-off-by: Yacov Manevich &lt;yacov.manevich@avalabs.org&gt;
Co-authored-by: Sam Liokumovich &lt;65994425+samliok@users.noreply.github.com&gt;
diff --git a/timeout_handler.go b/timeout_handler.go
@@ -77,9 +77,9 @@ func (t *TimeoutHandler[T]) run(startTime time.Time) {
 }
 
 func (t *TimeoutHandler[T]) maybeRunTasks() {
+	t.lock.Lock()
 	ids := make([]T, 0, len(t.tasks))
 
-	t.lock.Lock()
 	for id := range t.tasks {
 		ids = append(ids, id)
 	}

Original file line number	Diff line number	Diff line change
`@@ -77,9 +77,9 @@ func (t *TimeoutHandler[T]) run(startTime time.Time) {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`func (t *TimeoutHandler[T]) maybeRunTasks() {`
	`80`	`+ t.lock.Lock()`
`80`	`81`	`ids := make([]T, 0, len(t.tasks))`
`81`	`82`
`82`		`- t.lock.Lock()`
`83`	`83`	`for id := range t.tasks {`
`84`	`84`	`ids = append(ids, id)`
`85`	`85`	`}`