fix race condition

Author: samliok

long_running_test.go

@@ -34,7 +34,6 @@ func TestLongRunningReplication(t *testing.T) {
 	net.StopAndAssert(false)
 }
 
-// Oh shoot, aws crashed node 3. will they recover....
 func TestLongRunningCrash(t *testing.T) {
 	net := testutil.NewDefaultLongRunningNetwork(t, 10)
 	for i, instance := range net.Instances {

testutil/long_running_network.go

@@ -71,9 +71,10 @@ func (n *LongRunningInMemoryNetwork) CrashNodes(nodeIndexes ...uint64) {
 
 func (n *LongRunningInMemoryNetwork) RestartNodes(nodeIndexes ...uint64) {
 	for _, idx := range nodeIndexes {
+		n.lock.Lock()
 		instance := n.Instances[idx]
+
 		nodeID := instance.E.ID
-		logger := instance.l
 		bb := instance.BB
 		clonedWal := instance.WAL.Clone()
 		clonedStorage := instance.Storage.Clone()
@@ -82,13 +83,14 @@ func (n *LongRunningInMemoryNetwork) RestartNodes(nodeIndexes ...uint64) {
 			BlockBuilder:       bb,
 			ReplicationEnabled: true,
 			MaxRoundWindow:     longRunningMaxRoundWindow,
-			Logger:             logger,
+			Logger:             instance.l,
 			WAL:                clonedWal,
 			Storage:            clonedStorage,
 			StartTime:          instance.currentTime.Load(),
 		})
 
 		n.Instances[idx] = newNode
+		n.lock.Unlock()
 		newNode.Start()
 	}
 }