move sync to start

Author: samliok

epoch.go

@@ -273,6 +273,7 @@ func (e *Epoch) Start() error {
 	}
 	// Only init receiving messages once you have initialized the data structures required for it.
 	defer func() {
+		e.broadcastReplicationSync()
 		e.canReceiveMessages.Store(true)
 	}()
 	return e.restoreFromWal()
@@ -501,8 +502,6 @@ func (e *Epoch) broadcastReplicationSync() {
 func (e *Epoch) resumeFromWal(highestRoundRecord *walRound) error {
 	e.Logger.Info("Most relevant record recovered from WAL", zap.Uint64("round", highestRoundRecord.round), zap.Stringer("relevant", highestRoundRecord))
 
-	e.broadcastReplicationSync()
-
 	// Handle the most relevant record based on priority: finalization > notarization > emptyNotarization > emptyVote > block
 	if highestRoundRecord.finalization != nil {
 		finalizationMsg := &Message{Finalization: highestRoundRecord.finalization}

recovery_test.go

@@ -969,14 +969,6 @@ func TestRecoveryAndBroadcast(t *testing.T) {
 	require.Equal(t, startSeq, normalNode3.Storage.NumBlocks())
 	require.Equal(t, uint64(2), laggingNode.Storage.NumBlocks())
 
-	blockBytes, err := storageData[0].VerifiedBlock.Bytes()
-	require.NoError(t, err)
-	blockRecord := BlockRecord(storageData[0].VerifiedBlock.BlockHeader(), blockBytes)
-	_, finalizationRecord := testutil.NewFinalizationRecord(t, laggingNode.E.EpochConfig.Logger, laggingNode.E.EpochConfig.SignatureAggregator, storageData[0].VerifiedBlock, nodes)
-
-	laggingNode.WAL.Append(blockRecord)
-	laggingNode.WAL.Append(finalizationRecord)
-
 	normalNode1.Start()
 	normalNode2.Start()
 	normalNode3.Start()