Potential testing Idea

[samliok]

Instead of manually advancing the rounds in our tests what if we had this type of structure

net := createNetwork(nodes)
net.run() // this runs in the background triggering the block builder every 50ms

// network actions such as 
// net.changeMessageFilter
// net.disconnectNode
// ex.

net.waitRounds(50) // waits for approximately 50 rounds to progress
net.disconnect(nodes[0])
net.waitRounds(50) // another 50 rounds
net.connect(nodes[0])
net.crashAndRecover(nodes[0])
net.waitRounds(50)
net.Stop() // stop can also ensure consistency across nodes Storage

just a thought, wanted to note the idea down before i forget it.

[samliok]

this way we can test recovery, replication, dropping of messages while other nodes are progressing.

[samliok]

also could be usefull to have a net.HealthCheck() which ensures things like wal & storage health. Ex. it can ensure we don't have duplicate entries in the wal

[yacovm]

We can have tests similar to what you describe, but I don't think we should have them instead of existing ones, as these are not deterministic.

There is value in deterministic tests, and usually a test that is not deterministic and depends on timing (e.g triggering a block builder every 50ms) flakes often in CI.

[samliok]

we should also have a helper that advanced the time and checks for old timeout tasks that haven't been removed.