Skip to content

Commit 9c3de16

Browse files
author
Tony Zhang
committed
addressing feedback
1 parent e55a1f8 commit 9c3de16

File tree

6 files changed

+58334
-11009
lines changed

6 files changed

+58334
-11009
lines changed

.github/workflows/unit-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Install Go dependencies
2727
run: go mod download
2828

29-
- name: Build and Testga.
29+
- name: Build and Test
3030
working-directory: ${{ github.workspace }}
3131
run: |
3232
scripts/build.sh

scripts/check_total_coverage.sh

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,25 @@
11
#!/usr/bin/env bash
22

33
coverage_dir=$(PWD)/coverage
4-
combined_coverage_file=$coverage_dir/combined.txt
4+
merged_coverage_dir=$coverage_dir/merged
5+
merged_coverage_file=$merged_coverage_dir/merged.txt
56
COVERAGE_THRESHOLD=15.0 # percentage threshold of code coverage required
67

8+
echo "Recreating merged coverage directory..."
9+
rm -rf ${merged_coverage_dir}
10+
mkdir -p ${merged_coverage_dir}
11+
712
echo "Generating coverage report in text format..."
813
included_packages=$(go list ./... | grep -v /tests/ | grep -v '/sdk/') # not including 'tests' and 'sdk'
9-
go tool covdata merge -i=$coverage_dir/e2e,$coverage_dir/ut -o=$coverage_dir -pkg=${included_packages//$'\n'/,}
10-
go tool covdata textfmt -i=./coverage -o $combined_coverage_file
11-
go tool cover -func $combined_coverage_file
14+
go tool covdata merge -i=$coverage_dir/e2e,$coverage_dir/ut -o=$merged_coverage_dir -pkg=${included_packages//$'\n'/,}
15+
go tool covdata textfmt -i=$merged_coverage_dir -o $merged_coverage_file
16+
go tool cover -func $merged_coverage_file
1217

1318
echo "Checking total coverage..."
1419

15-
# print current test coverage from report
16-
current_test_coverage=$(go tool cover -func=$combined_coverage_file | grep -e "total" | awk '{print $3}')
17-
echo "Current test coverage is $current_test_coverage"
20+
# TODO: coverage details will be output as a comment in the PR
1821

19-
go tool cover -func=$combined_coverage_file | grep -e "total" | \
22+
go tool cover -func=$merged_coverage_file | grep -e "total" | \
2023
awk -v coverageThreshold=$COVERAGE_THRESHOLD '{if (($3 - 0.0) < coverageThreshold) \
2124
{print "Coverage is less than", coverageThreshold, "%. Checking Failed"; exit 1} \
2225
else \

0 commit comments

Comments
 (0)