adding network hardclean e2e test

Author: Tony Zhang

tests/e2e/commands/network.go

@@ -32,7 +32,7 @@ func CleanNetwork() (string, error) {
 }
 
 /* #nosec G204 */
-func CleanNetworkHard() {
+func CleanNetworkHard() (string, error) {
 	output, err := utils.TestCommand(
 		utils.NetworkCmd,
 		"clean",
@@ -47,7 +47,7 @@ func CleanNetworkHard() {
 		fmt.Println(output)
 		utils.PrintStdErr(err)
 	}
-	gomega.Expect(err).Should(gomega.BeNil())
+	return output, err
 }
 
 /* #nosec G204 */

tests/e2e/testcases/network/clean/suite.go

@@ -4,7 +4,11 @@
 package network
 
 import (
+	"path"
+
+	"github.com/ava-labs/avalanche-cli/sdk/utils"
 	"github.com/ava-labs/avalanche-cli/tests/e2e/commands"
+	testUtils "github.com/ava-labs/avalanche-cli/tests/e2e/utils"
 	ginkgo "github.com/onsi/ginkgo/v2"
 	"github.com/onsi/gomega"
 )
@@ -24,4 +28,17 @@ var _ = ginkgo.Describe("[Local Network] Clean", ginkgo.Ordered, func() {
 		gomega.Expect(err).Should(gomega.BeNil())
 		gomega.Expect(out).Should(gomega.ContainSubstring("No network is running"))
 	})
+
+	ginkgo.It("hard clean should remove downloaded avalanchego and plugins", func() {
+		out := commands.StartNetwork()
+		gomega.Expect(out).Should(gomega.ContainSubstring("Network ready to use"))
+
+		out, err := commands.CleanNetworkHard()
+		gomega.Expect(err).Should(gomega.BeNil())
+		gomega.Expect(out).Should(gomega.ContainSubstring("All existing binaries removed"))
+
+		// check if binaries are removed
+		binDirExists := utils.DirExists(path.Join(testUtils.GetBaseDir(), "bin"))
+		gomega.Expect(binDirExists).Should(gomega.BeFalse())
+	})
 })

tests/e2e/testcases/packageman/suite.go

@@ -30,7 +30,7 @@ var _ = ginkgo.Describe("[Package Management]", ginkgo.Ordered, func() {
 		gomega.Expect(err).Should(gomega.BeNil())
 	})
 	ginkgo.BeforeEach(func() {
-		commands.CleanNetworkHard()
+		_, _ = commands.CleanNetworkHard()
 	})
 
 	ginkgo.AfterEach(func() {

tests/e2e/testcases/upgrade/non-sov/suite.go

@@ -51,7 +51,7 @@ var (
 // need to have this outside the normal suite because of the BeforeEach
 var _ = ginkgo.Describe("[Upgrade expect network failure non SOV]", ginkgo.Ordered, func() {
 	ginkgo.AfterEach(func() {
-		commands.CleanNetworkHard()
+		_, _ = commands.CleanNetworkHard()
 		err := utils.DeleteConfigs(subnetName)
 		gomega.Expect(err).Should(gomega.BeNil())
 	})
@@ -91,7 +91,7 @@ var _ = ginkgo.Describe("[Upgrade expect network failure non SOV]", ginkgo.Order
 // and then check the file is there and has the correct content.
 var _ = ginkgo.Describe("[Upgrade public network non SOV]", ginkgo.Ordered, func() {
 	ginkgo.AfterEach(func() {
-		commands.CleanNetworkHard()
+		_, _ = commands.CleanNetworkHard()
 		err := utils.DeleteConfigs(subnetName)
 		gomega.Expect(err).Should(gomega.BeNil())
 	})
@@ -158,7 +158,7 @@ var _ = ginkgo.Describe("[Upgrade local network non SOV]", ginkgo.Ordered, func(
 	})
 
 	ginkgo.AfterEach(func() {
-		commands.CleanNetworkHard()
+		_, _ = commands.CleanNetworkHard()
 		err := utils.DeleteConfigs(subnetName)
 		gomega.Expect(err).Should(gomega.BeNil())
 		err = utils.DeleteConfigs(secondSubnetName)

tests/e2e/testcases/upgrade/sov/suite.go

@@ -51,7 +51,7 @@ var (
 // need to have this outside the normal suite because of the BeforeEach
 var _ = ginkgo.Describe("[Upgrade expect network failure SOV]", ginkgo.Ordered, func() {
 	ginkgo.AfterEach(func() {
-		commands.CleanNetworkHard()
+		_, _ = commands.CleanNetworkHard()
 		err := utils.DeleteConfigs(subnetName)
 		gomega.Expect(err).Should(gomega.BeNil())
 	})
@@ -91,7 +91,7 @@ var _ = ginkgo.Describe("[Upgrade expect network failure SOV]", ginkgo.Ordered,
 // and then check the file is there and has the correct content.
 var _ = ginkgo.Describe("[Upgrade public network SOV]", ginkgo.Ordered, func() {
 	ginkgo.AfterEach(func() {
-		commands.CleanNetworkHard()
+		_, _ = commands.CleanNetworkHard()
 		err := utils.DeleteConfigs(subnetName)
 		gomega.Expect(err).Should(gomega.BeNil())
 	})
@@ -158,7 +158,7 @@ var _ = ginkgo.Describe("[Upgrade local network SOV]", ginkgo.Ordered, func() {
 	})
 
 	ginkgo.AfterEach(func() {
-		commands.CleanNetworkHard()
+		_, _ = commands.CleanNetworkHard()
 		err := utils.DeleteConfigs(subnetName)
 		gomega.Expect(err).Should(gomega.BeNil())
 		err = utils.DeleteConfigs(secondSubnetName)