[Bug]: When trying to deploy the ICTT contracts following the guide i get the error: max code size exceeded

[PietroFaggion]

Describe the bug
Following the guide at the link

https://build.avax.network/academy/interchain-token-transfer/06-erc-20-to-erc-20-bridge/06-deploy-with-avalanche-cli

when i execute the command avalanche ictt deploy after indicating the address of the ERC20 (this ERC20 was deployed through Avalanche cli) which needs the new Home Token i get the max code size exceeded error.
I've tried to deploy a L1 with a 120KB max code size (setting it in the genesis file) but it didn't change anything. I've tried to look for the error in the repositories of avalanche-cli, avalanchego and subnet-evm and what i'm supposing is that where you do the checks you're taking the max contract size from somewhere hardcoded and not dynamically based on the genesis file of the specific VM causing this issue.
Anyway us users do not have any control regarding what is being deployed so it must be an issue on coding side.

To Reproduce
Simply trying to deploy the ictt contracts through the avalanche cli commands

Expected behavior
It should deploy, as of the guide above, the ictt contracts on my L1

Screenshots
If applicable, add screenshots to help explain your problem.

Logs
avalanche ictt deploy
✔ Fuji Testnet
✔ C-Chain
Home RPC Endpoint: api.avax-test.network/ext/bc/C/rpc
✔ Deploy a new Home for the token
✔ Enter the address of the ERC-20 Token: 0x07a390823B43369e85b3f81c1387fF1697dd1f8e
✔ Get private key from an existing stored key (created from avalanche key create or avalanche key import)
✔ avafuji
✔ Blockchain ispcktest3
Which is the RPC endpoint for ispcktest3: 127.0.0.1:9650/ext/bc/FCh52jnNELXiZaMGBmBmCX4rqgYTeUNx5J2tB4vereQpKHSkU/rpc
Remote RPC Endpoint: 127.0.0.1:9650/ext/bc/FCh52jnNELXiZaMGBmBmCX4rqgYTeUNx5J2tB4vereQpKHSkU/rpc
✔ Use the private key of the Genesis Allocated address 0x63208f0f50Cd0FA10C1FB979c46Dc5740C096fFC
Downloading Avalanche ICTT Contracts
Compiling Avalanche ICTT Contracts
Error: max code size exceeded

Operating System
Linux

Additional context
Add any other context about the problem here.

[felipemadero]

Hi @PietroFaggion and thanks for the detailed feedback. CLI by default installs latest foundry for smart contract
compilation, but latest foundry version started producing unoptimized binaries. So the command was indeed not working by
default. That is the reason for the max code size exceeded returned by c-chain. We made a PR #2669 to hardcode the foundry version to a one that fulfills our need. Also we improved some error messages to better point to a part of code in case of ictt deploy error.
Regarding control over deployed code, the only available for this command is the --version flag which controls
which commit of ICTT source code to use.

For the moment on, you should rm current found setup, rm -rf ~/.foundry/
and use a version of CLI compiled from the hardcode-foundry-version branch

[PietroFaggion]

Thanks for the feedback, the problem is that when i try to do this

### and use a version of CLI compiled from the hardcode-foundry-version branch

I'm not sure if it's viable beacuse lanuching the install.sh script looks automatically for the latest version so i think that it will still download the avalanche cli compiled from the main branch. I'm doing some tests to see if i can avoid that script with the make command but i'm facing issues with the syntax of the Makefile:

Makefile:50: *** missing separator. Stop.

Please keep me updated if you merge the branch or any other improvements that can help me with this issue

[PietroFaggion]

I confirm that with the install.sh script it does not work but building avalanche-cli through its build script and then copying the binary wherever you need fix the problem. I've now encountered other problems but the max code size error is gone

[felipemadero]

In general, you can clone the repo, checkout a desired branch, and then compile it.

You will need to have golang installed (tested with go 1.22.11).

git clone https://github.com/ava-labs/avalanche-cli
cd avalanche-cli
git checkout hardcode-foundry-version
./scripts/build.sh ~/bin/avalanche

Besides this, currently working on generaste a rc for you to install using the install script.

[felipemadero]

Install script will only install releases, or rc, but not any given branch.

[PietroFaggion]

yeah i can confirm, that's the approach i used for avalanche cli and it's working. I don't know if it's better to open a different git issue but i'm now having this problem:

avalanche ictt deploy ✔ Fuji Testnet ✔ C-Chain Home RPC Endpoint: https://api.avax-test.network/ext/bc/C/rpc ✔ A token that already has a Home deployed (recommended) Enter the address of the Home: 0xFB12991F0f3aAC7eaa0f893E8BA283FD1C7E24Fb 8BA283FD1C7E24Fb█ ✔ Get private key from an existing stored key (created from avalanche key create or avalanche key import) ✔ avafuji ✔ Blockchain ispcktest What is the RPC endpoint for ispcktest: http://127.0.0.1:9650/ext/bc/adotdGgt7Y117xvkxraQoj39VRRnY6AiMfcuKgX4Uxpcny4RU/rpc ✔ What is the RPC endpoint for ispcktest: http://127.0.0.1:9650/ext/bc/adotdGgt7Y117xvkxraQoj39VRRnY6AiMfcuKgX4Uxpcny4RU/rpc█ ✔ Use the private key of the Genesis Allocated address 0xa77FFc7B814986BC8F909c68e7110B72435Dca14 Downloading Avalanche ICTT Contracts Compiling Avalanche ICTT Contracts Remote Deployed to http://127.0.0.1:9650/ext/bc/adotdGgt7Y117xvkxraQoj39VRRnY6AiMfcuKgX4Uxpcny4RU/rpc Remote Address: 0x1abD2F972da5c4eEf73FaEbAD96F31755818C2d0 Registering remote contract with home contract
Error: timeout waiting for remote endpoint registration

and looking in the code of avalanche cli code (line 691 of avalanche-cli\cmd\interchaincmd\tokentransferrercmd\deploy.go) i see:

checkInterval := 100 * time.Millisecond checkTimeout := 10 * time.Second t0 := time.Now() var collateralNeeded *big.Int for { registeredRemote, err := ictt.TokenHomeGetRegisteredRemote( homeRPCEndpoint, homeAddress, remoteBlockchainID, remoteAddress, ) if err != nil { return err } if registeredRemote.Registered { collateralNeeded = registeredRemote.CollateralNeeded break } elapsed := time.Since(t0) if elapsed > checkTimeout { return fmt.Errorf("timeout waiting for remote endpoint registration") } time.Sleep(checkInterval) }

this (if i'm not reading badly the code) gives me 10 seconds to register the remote/home smart contract, having a bad internet connection 10 seconds may be too much restrictive