Skip to content

Commit 20669e6

Browse files
aaronbuchwaldclaude
andcommitted
Restrict benchmark auto-push to scheduled runs only
Previously, workflow_dispatch runs on master also auto-pushed benchmark results to gh-pages. This allowed one-off manual runs with arbitrary runners/configs to create permanent graph entries on the benchmark dashboard, cluttering it with near-empty graphs that would never receive new data points. Restrict auto-push to only schedule events so that only codified benchmark configurations in the schedule matrix produce persistent tracking data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent ed8730b commit 20669e6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/c-chain-reexecution-benchmark-container.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
prometheus-push-url: ${{ secrets.PROMETHEUS_PUSH_URL || '' }}
131131
prometheus-username: ${{ secrets.PROMETHEUS_USERNAME || '' }}
132132
prometheus-password: ${{ secrets.PROMETHEUS_PASSWORD || '' }}
133-
push-github-action-benchmark: ${{ (github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.repository == 'ava-labs/avalanchego' && github.ref_name == 'master')) && matrix.firewood-ref == '' }}
133+
push-github-action-benchmark: ${{ github.event_name == 'schedule' }}
134134
skip-benchmark-comparison: ${{ matrix.firewood-ref != '' || matrix.libevm-ref != '' }}
135135
aws-role: ${{ github.event.inputs.push-post-state != '' && secrets.AWS_S3_RW_ROLE || secrets.AWS_S3_READ_ONLY_ROLE }}
136136
aws-region: 'us-east-2'

.github/workflows/c-chain-reexecution-benchmark-gh-native.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ jobs:
120120
prometheus-push-url: ${{ secrets.PROMETHEUS_PUSH_URL || '' }}
121121
prometheus-username: ${{ secrets.PROMETHEUS_USERNAME || '' }}
122122
prometheus-password: ${{ secrets.PROMETHEUS_PASSWORD || '' }}
123-
push-github-action-benchmark: ${{ (github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.repository == 'ava-labs/avalanchego' && github.ref_name == 'master')) && matrix.firewood-ref == '' }}
123+
push-github-action-benchmark: ${{ github.event_name == 'schedule' }}
124124
skip-benchmark-comparison: ${{ matrix.firewood-ref != '' || matrix.libevm-ref != '' }}
125125
aws-role: ${{ github.event.inputs.push-post-state != '' && secrets.AWS_S3_RW_ROLE || secrets.AWS_S3_READ_ONLY_ROLE }}
126126
aws-region: 'us-east-2'

0 commit comments

Comments
 (0)