fix: doubled toasts, receive address pre-selection (#777)

Author: meeh0w

…pages/Send/lib/getAddressTypeForToken.ts …s/next/src/lib/getAddressTypeForToken.tsapps/next/src/pages/Send/lib/getAddressTypeForToken.ts renamed to apps/next/src/lib/getAddressTypeForToken.ts apps/next/src/pages/Send/lib/getAddressTypeForToken.ts renamed to apps/next/src/lib/getAddressTypeForToken.ts

@@ -33,6 +33,7 @@ import { useNextUnifiedBridgeContext } from '@/pages/Bridge/contexts';
 import { chainIdToCaip } from '@core/common';
 import { FaExplosion } from 'react-icons/fa6';
 import { NoScrollStack } from '@/components/NoScrollStack';
+import { getAddressTypeForToken } from '@/lib/getAddressTypeForToken';
 
 const ICON_SIZE = 20;
 
@@ -155,8 +156,15 @@ export const PortfolioActionButtons = ({
             icon={<QrCodeIcon size={ICON_SIZE} />}
             label={t('Receive')}
             onClick={() => {
-              capture('TokenReceiveClicked', { addressType: 'C' });
-              history.push(`/receive?accId=${activeAccount?.id}`);
+              const addressType = token ? getAddressTypeForToken(token) : 'C';
+
+              capture('TokenReceiveClicked', { addressType });
+
+              const params = new URLSearchParams({
+                addressType,
+                accId: activeAccount?.id ?? '',
+              });
+              history.push(`/receive?${params.toString()}`);
             }}
           />
         </OfflineTooltip>

apps/next/src/pages/Portfolio/components/PortfolioHome/components/PortolioDetails/components/PortfolioActionButtons.tsx

@@ -30,7 +30,7 @@ import { useTokensForAccount } from '@/hooks/useTokensForAccount';
 import { getAddressByType } from '@/utils/getAddressByType';
 
 import { SendBody } from './components/SendBody';
-import { getAddressTypeForToken } from './lib/getAddressTypeForToken';
+import { getAddressTypeForToken } from '../../lib/getAddressTypeForToken';
 
 const POLLED_BALANCES = [TokenType.NATIVE, TokenType.ERC20];
 

apps/next/src/pages/Send/Send.tsx

@@ -1,16 +1,12 @@
-import { useHistory } from 'react-router-dom';
 import { useTranslation } from 'react-i18next';
-import { ChevronRightIcon, IconButton, toast } from '@avalabs/k2-alpine';
+import { toast } from '@avalabs/k2-alpine';
 
 import {
-  getExplorerAddressByNetwork,
   isMissingBtcWalletPolicyError,
   isUserRejectionError,
-  openNewTab,
 } from '@core/common';
 import { NetworkWithCaipId } from '@core/types';
 import { useAnalyticsContext } from '@core/ui';
-import { useConfettiContext } from '@/components/Confetti';
 
 const TOAST_ID = 'send-result';
 
@@ -19,8 +15,6 @@ export const useTransactionCallbacks = (
   fromAddress?: string,
 ) => {
   const { t } = useTranslation();
-  const { replace } = useHistory();
-  const { triggerConfetti } = useConfettiContext();
   const { captureEncrypted } = useAnalyticsContext();
 
   return {
@@ -41,13 +35,6 @@ export const useTransactionCallbacks = (
           chainId: network?.chainId,
         });
       }
-      // Redirect to home page
-      replace('/');
-      triggerConfetti();
-      toast.success(t('Transaction successful'), {
-        id: TOAST_ID,
-        action: <ExplorerLink network={network} hash={hash} />,
-      });
     },
     // When transaction could not be sent to the network or failed immediately
     onSendFailure: (err: unknown) => {
@@ -63,24 +50,3 @@ export const useTransactionCallbacks = (
     },
   };
 };
-
-const ExplorerLink = ({
-  network,
-  hash,
-}: {
-  network: NetworkWithCaipId;
-  hash: string;
-}) => (
-  <IconButton
-    size="small"
-    sx={{ color: 'background.default', padding: 0 }}
-    onClick={() => {
-      toast.dismiss(TOAST_ID);
-      openNewTab({
-        url: getExplorerAddressByNetwork(network, hash, 'tx'),
-      });
-    }}
-  >
-    <ChevronRightIcon size={18} />
-  </IconButton>
-);

apps/next/src/pages/Send/components/SendBody/hooks/useTransactionCallbacks.tsx

@@ -24,6 +24,7 @@ export const getChainLabelAndIconByAddressType = memoize(
           Icon: AvalancheColorIcon,
         };
       case 'AVM':
+      case 'PVM':
         return {
           label: 'Avalanche X/P-Chain',
           Icon: FixedXPChainIcon,