code review

Author: atn4z7

packages/core-mobile/app/new/features/notifications/screens/NotificationsScreen.tsx

@@ -35,7 +35,7 @@ import {
   isPriceAlertNotification,
   isBalanceChangeNotification
 } from '../types'
-import { isSwapCompletedOrFailed } from '../utils'
+import { isSwapTerminal } from '../utils'
 import { FusionTransferItem } from '../components/FusionTransferItem'
 
 const TITLE = 'Notifications'
@@ -176,7 +176,7 @@ export const NotificationsScreen = (): JSX.Element => {
       combinedItems.filter(
         item =>
           item.kind === 'notification' ||
-          (item.kind === 'swap' && isSwapCompletedOrFailed(item.item.transfer))
+          (item.kind === 'swap' && isSwapTerminal(item.item.transfer))
       ),
     [combinedItems]
   )
@@ -292,16 +292,16 @@ export const NotificationsScreen = (): JSX.Element => {
 
       if (combined.kind === 'swap') {
         const transfer = combined.item
-        const isCompletedOrFailed = isSwapCompletedOrFailed(transfer.transfer)
+        const isTerminal = isSwapTerminal(transfer.transfer)
         return (
           <SwipeableRow
             animateOut={
-              isCompletedOrFailed && isClearingAll && index < MAX_ANIMATED_ITEMS
+              isTerminal && isClearingAll && index < MAX_ANIMATED_ITEMS
             }
             animateDelay={index * SWIPE_DELAY}
             onSwipeComplete={() => removeTransfer(transfer.transfer.id)}
             onPress={() => handleSwapActivityPress(transfer)}
-            enabled={!isClearingAll && isCompletedOrFailed}>
+            enabled={!isClearingAll && isTerminal}>
             <FusionTransferItem
               item={transfer}
               showSeparator={!isLast}

packages/core-mobile/app/new/features/notifications/screens/SwapActivityDetailScreen.tsx

@@ -53,7 +53,7 @@ export const SwapActivityDetailScreen = (): JSX.Element => {
     }
     return (
       <Button size="large" type="primary" onPress={handleDismiss}>
-        {'Hide'}
+        Hide
       </Button>
     )
   }

packages/core-mobile/app/new/features/notifications/utils.test.ts

@@ -2,7 +2,7 @@ import type { Transfer } from '@avalabs/fusion-sdk'
 import { AppNotification, NotificationCategory, NotificationTab } from './types'
 import {
   filterByTab,
-  isSwapCompletedOrFailed,
+  isSwapTerminal,
   mapTransferToSourceChainStatus,
   mapTransferToSwapStatus,
   mapTransferToTargetChainStatus,
@@ -148,33 +148,31 @@ describe('mapTransferToSwapStatus', () => {
   )
 })
 
-// ─── isSwapCompletedOrFailed ────────────────────────────────────────────────────────
+// ─── isSwapTerminal ────────────────────────────────────────────────────────
 
-describe('isSwapCompletedOrFailed', () => {
+describe('isSwapTerminal', () => {
   it('returns true when the swap is completed', () => {
-    expect(isSwapCompletedOrFailed(makeTransfer('completed'))).toBe(true)
+    expect(isSwapTerminal(makeTransfer('completed'))).toBe(true)
   })
 
   it('returns true when the swap has failed', () => {
-    expect(isSwapCompletedOrFailed(makeTransfer('failed'))).toBe(true)
+    expect(isSwapTerminal(makeTransfer('failed'))).toBe(true)
   })
 
   it('returns true when the swap was refunded (partial failure)', () => {
-    expect(isSwapCompletedOrFailed(makeTransfer('refunded'))).toBe(true)
+    expect(isSwapTerminal(makeTransfer('refunded'))).toBe(true)
   })
 
   it('returns false when the swap is in progress (source-pending)', () => {
-    expect(isSwapCompletedOrFailed(makeTransfer('source-pending'))).toBe(false)
+    expect(isSwapTerminal(makeTransfer('source-pending'))).toBe(false)
   })
 
   it('returns false when the swap is in progress (target-pending)', () => {
-    expect(isSwapCompletedOrFailed(makeTransfer('target-pending'))).toBe(false)
+    expect(isSwapTerminal(makeTransfer('target-pending'))).toBe(false)
   })
 
   it('returns false when the swap is in progress (source-completed)', () => {
-    expect(isSwapCompletedOrFailed(makeTransfer('source-completed'))).toBe(
-      false
-    )
+    expect(isSwapTerminal(makeTransfer('source-completed'))).toBe(false)
   })
 })
 

packages/core-mobile/app/new/features/notifications/utils.ts

@@ -15,7 +15,7 @@ import {
  * the user can track them; only terminal states (completed / failed / refunded)
  * are eligible for removal.
  */
-export function isSwapCompletedOrFailed(transfer: Transfer): boolean {
+export function isSwapTerminal(transfer: Transfer): boolean {
   const status = mapTransferToSwapStatus(transfer)
   return status === 'completed' || status === 'failed' || status === 'refunded'
 }