QA - fix flakiness (#3582)

Author: eunjisong

packages/core-mobile/app/new/features/activity/components/ActivityList.tsx

@@ -144,6 +144,7 @@ const SectionHeader = ({
         backgroundColor: theme.colors.$surfacePrimary
       }}>
       <Text
+        testID="section_header"
         variant="heading3"
         sx={{
           color: theme.colors.$textPrimary

packages/core-mobile/e2e-appium/helpers/actions.ts

@@ -305,7 +305,7 @@ async function typeSlowly(
   }
 }
 
-async function assertPerformance(start: number, expectedTime = 10000) {
+async function assertPerformance(start: number, expectedTime = 20000) {
   const end = performance.now()
   const totalTime = end - start
   const passed = totalTime <= expectedTime

packages/core-mobile/e2e-appium/pages/commonEls.page.ts

@@ -3,6 +3,7 @@ import { actions } from '../helpers/actions'
 import { selectors } from '../helpers/selectors'
 import commonEls from '../locators/commonEls.loc'
 import portfolioPage from './portfolio.page'
+import settingsPage from './settings.page'
 
 class CommonElsPage {
   get retryBtn() {
@@ -407,6 +408,13 @@ class CommonElsPage {
   }
 
   async dismissBottomSheet(element = this.grabber) {
+    await actions.delay(1000)
+    const backBtn =
+      !(await actions.getVisible(element)) &&
+      (await actions.getVisible(this.backButton))
+    if (backBtn) {
+      await actions.tap(this.backButton)
+    }
     await actions.waitFor(element, 30000)
     await actions.dragAndDrop(element, [0, 1500])
     await actions.delay(1000)
@@ -518,9 +526,12 @@ class CommonElsPage {
     await actions.waitForDisplayed(this.copied)
   }
 
-  async switchAccount(account = commonEls.secondAccount) {
+  async switchAccount(
+    account = commonEls.secondAccount,
+    walletName = 'Wallet 1'
+  ) {
     await this.goMyWallets()
-    await actions.tap(selectors.getById(`manage_accounts_list__${account}`))
+    await settingsPage.tapAccount(account, walletName)
   }
 
   async goMyWallets() {

packages/core-mobile/e2e-appium/pages/portfolio.page.ts

@@ -351,7 +351,7 @@ class PortfolioPage {
   async tapToken(token = 'Avalanche') {
     // It taps on the name of the token on the portfolio asset (ex - Avalanche, Bitcoin, Wrapped Ether...)
     token = token.replace(/^Avalanche [PX]-Chain$/, 'Avalanche')
-    await actions.tap(
+    await actions.click(
       selectors.getById(`${portfolio.portfolioTokenItem}${token}`)
     )
   }

packages/core-mobile/e2e-appium/pages/settings.page.ts

@@ -530,9 +530,6 @@ class Settings {
   }
 
   async tapCurrency() {
-    if (!(await actions.getVisible(this.currencyId))) {
-      await this.swipeSettings()
-    }
     await actions.tap(this.currencyId)
   }
 
@@ -557,15 +554,10 @@ class Settings {
     await actions.tap(this.showRecoveryPhrase)
   }
 
-  async createNthAccount(
-    account = 2,
-    activeAccount = settings.account,
-    walletName = 'Wallet 1'
-  ) {
-    await this.goSettings()
-    await this.tapManageAccountsBtn()
+  async createNthAccount(account = 2, walletName = 'Wallet 1') {
+    await common.goMyWallets()
     await this.addAccount(account, walletName)
-    await this.selectAccount(activeAccount, walletName)
+    await common.goBack()
   }
 
   async tapNetworks() {

packages/core-mobile/e2e-appium/pages/transactions.page.ts

@@ -505,7 +505,7 @@ class TransactionsPage {
     await this.tapWithdraw()
     await this.tapNext()
     await actions.tap(selectors.getById(`list_item__${token}`))
-    await actions.type(selectors.getById('fiat_amount_input'), '100')
+    await actions.type(selectors.getById('$ fiat_amount_input  '), '100')
     await actions.waitFor(this.errorMsg)
     await actions.isNotVisible(this.nextBtn)
     await actions.isVisible(this.nextBtnDisabled)

packages/core-mobile/e2e-appium/specs/performance/balance.spec.ts

@@ -1,12 +1,10 @@
 import warmup from '../../helpers/warmup'
 import { actions } from '../../helpers/actions'
 import portfolioPage from '../../pages/portfolio.page'
-import commonElsPage from '../../pages/commonEls.page'
 
 describe('[Performance] Balance', () => {
   it('Portfolio Performance - Balance Header', async () => {
     await warmup()
-    await actions.waitFor(commonElsPage.loadingSpinnerVisible)
     const start = performance.now()
     await portfolioPage.verifyBalanceHeader()
     await actions.assertPerformance(start)

packages/core-mobile/e2e-appium/specs/portfolioTab/assets/ownedTokenDetail.spec.ts

@@ -16,8 +16,11 @@ describe('Portfolio Assets', () => {
     xchain: ['Send']
   }
 
-  it('AVAX owned token detail', async () => {
+  before(async () => {
     await warmup()
+  })
+
+  it('AVAX owned token detail', async () => {
     await commonElsPage.filter(commonElsLoc.cChain_2)
     await portfolioPage.verifyOwnedTokenDetail('Avalanche', tokens.avax)
   })

packages/core-mobile/e2e-appium/specs/portfolioTab/defi/defi.spec.ts

@@ -60,7 +60,7 @@ describe('Portfolio tab', () => {
   })
 
   it('Defi - Should verify the empty defi screen', async () => {
-    await settingsPage.switchAccount('Account 2')
+    await settingsPage.createNthAccount(3)
     await portfolioPage.verifyEmptyDefiScreen()
   })
 })

packages/core-mobile/e2e-appium/specs/settings/currency.spec.ts

@@ -14,15 +14,13 @@ describe('Settings', () => {
     await settingsPage.selectCurrency('EUR')
     await settingsPage.tapCurrency()
     await settingsPage.verifyCurrencyScreen('EUR')
-    await commonElsPage.dismissBottomSheet()
+    await commonElsPage.goBack()
   })
 
   it('Currency - Should change currency back to USD', async () => {
-    await settingsPage.goSettings()
     await settingsPage.tapCurrency()
     await settingsPage.selectCurrency('USD')
     await settingsPage.tapCurrency()
     await settingsPage.verifyCurrencyScreen('USD')
-    await commonElsPage.dismissBottomSheet()
   })
 })