code review

Author: atn4z7

packages/core-mobile/app/new/features/swapV2/consts.ts

@@ -99,7 +99,7 @@ export const MAX_SLIPPAGE_PERCENT = 50
 /**
  * Markr API endpoint for Fusion SDK
  */
-// TODO add to env variables once stable
+// TODO add to env variables once stable https://ava-labs.atlassian.net/browse/CP-13381
 export const MARKR_API_URL =
   Config.MARKR_API_URL ?? 'https://proxy-api.avax.network/proxy/markr-staging'
 

packages/core-mobile/ios/Podfile.lock

@@ -543,7 +543,6 @@ PODS:
     - glog
     - hermes-engine
     - NitroModules
-    - QuickCrypto
     - RCT-Folly (= 2024.11.18.00)
     - RCTRequired
     - RCTTypeSafety
@@ -616,35 +615,10 @@ PODS:
     - ReactCommon/turbomodule/bridging
     - ReactCommon/turbomodule/core
     - Yoga
+  - OpenSSL-Universal (1.1.1100)
   - OpenTelemetrySwiftApi (1.13.1)
   - PLCrashReporter (1.12.0)
   - PromisesObjC (2.4.0)
-  - QuickCrypto (1.0.7):
-    - DoubleConversion
-    - glog
-    - hermes-engine
-    - NitroModules
-    - RCT-Folly (= 2024.11.18.00)
-    - RCTRequired
-    - RCTTypeSafety
-    - React-callinvoker
-    - React-Core
-    - React-debug
-    - React-Fabric
-    - React-featureflags
-    - React-graphics
-    - React-hermes
-    - React-ImageManager
-    - React-jsi
-    - React-NativeModulesApple
-    - React-RCTFabric
-    - React-renderercss
-    - React-rendererdebug
-    - React-utils
-    - ReactCodegen
-    - ReactCommon/turbomodule/bridging
-    - ReactCommon/turbomodule/core
-    - Yoga
   - RCT-Folly (2024.11.18.00):
     - boost
     - DoubleConversion
@@ -2314,6 +2288,32 @@ PODS:
     - ReactCommon/turbomodule/bridging
     - ReactCommon/turbomodule/core
     - Yoga
+  - react-native-quick-crypto (0.7.15):
+    - DoubleConversion
+    - glog
+    - hermes-engine
+    - OpenSSL-Universal
+    - RCT-Folly (= 2024.11.18.00)
+    - RCTRequired
+    - RCTTypeSafety
+    - React
+    - React-Core
+    - React-debug
+    - React-Fabric
+    - React-featureflags
+    - React-graphics
+    - React-hermes
+    - React-ImageManager
+    - React-jsi
+    - React-NativeModulesApple
+    - React-RCTFabric
+    - React-renderercss
+    - React-rendererdebug
+    - React-utils
+    - ReactCodegen
+    - ReactCommon/turbomodule/bridging
+    - ReactCommon/turbomodule/core
+    - Yoga
   - react-native-restart (0.0.27):
     - React-Core
   - react-native-safe-area-context (5.5.2):
@@ -3522,7 +3522,7 @@ DEPENDENCIES:
   - NitroAvalabsCrypto (from `../node_modules/react-native-nitro-avalabs-crypto`)
   - NitroFetch (from `../node_modules/react-native-nitro-fetch`)
   - NitroModules (from `../node_modules/react-native-nitro-modules`)
-  - QuickCrypto (from `../node_modules/react-native-quick-crypto`)
+  - OpenSSL-Universal (= 1.1.1100)
   - RCT-Folly (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)
   - RCT-Folly/Fabric (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)
   - RCTDeprecation (from `../node_modules/react-native/ReactApple/Libraries/RCTFoundation/RCTDeprecation`)
@@ -3574,6 +3574,7 @@ DEPENDENCIES:
   - react-native-passkey (from `../node_modules/react-native-passkey`)
   - react-native-performance (from `../node_modules/react-native-performance`)
   - react-native-quick-base64 (from `../node_modules/react-native-quick-base64`)
+  - react-native-quick-crypto (from `../node_modules/react-native-quick-crypto`)
   - react-native-restart (from `../node_modules/react-native-restart`)
   - react-native-safe-area-context (from `../node_modules/react-native-safe-area-context`)
   - "react-native-skia (from `../node_modules/@shopify/react-native-skia`)"
@@ -3678,6 +3679,7 @@ SPEC REPOS:
     - lottie-ios
     - MultiplatformBleAdapter
     - nanopb
+    - OpenSSL-Universal
     - OpenTelemetrySwiftApi
     - PLCrashReporter
     - PromisesObjC
@@ -3778,8 +3780,6 @@ EXTERNAL SOURCES:
     :path: "../node_modules/react-native-nitro-fetch"
   NitroModules:
     :path: "../node_modules/react-native-nitro-modules"
-  QuickCrypto:
-    :path: "../node_modules/react-native-quick-crypto"
   RCT-Folly:
     :podspec: "../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec"
   RCTDeprecation:
@@ -3878,6 +3878,8 @@ EXTERNAL SOURCES:
     :path: "../node_modules/react-native-performance"
   react-native-quick-base64:
     :path: "../node_modules/react-native-quick-base64"
+  react-native-quick-crypto:
+    :path: "../node_modules/react-native-quick-crypto"
   react-native-restart:
     :path: "../node_modules/react-native-restart"
   react-native-safe-area-context:
@@ -4095,13 +4097,13 @@ SPEC CHECKSUMS:
   LVModalQueue: 79984475a7adaccb33e8e3ef9ad06742852ff81b
   MultiplatformBleAdapter: b1fddd0d499b96b607e00f0faa8e60648343dc1d
   nanopb: fad817b59e0457d11a5dfbde799381cd727c1275
-  NitroAvalabsCrypto: 51a5d05222529a10c7ac99d963bab93fb1070072
+  NitroAvalabsCrypto: 1e5e1dbdc072022443c355b70d6d598841bf8557
   NitroFetch: 23ea318ee7382714fc4d32a4777583dba391833a
   NitroModules: 6a2c62dd870fa31c50daa55b63f59adecc68a8eb
+  OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c
   OpenTelemetrySwiftApi: aaee576ed961e0c348af78df58b61300e95bd104
   PLCrashReporter: db59ef96fa3d25f3650040d02ec2798cffee75f2
   PromisesObjC: f5707f49cb48b9636751c5b2e7d227e43fba9f47
-  QuickCrypto: d18e0bbaba69c477f6d6296175322d058da6f28a
   RCT-Folly: 36fe2295e44b10d831836cc0d1daec5f8abcf809
   RCTDeprecation: 5f638f65935e273753b1f31a365db6a8d6dc53b5
   RCTRequired: 8b46a520ea9071e2bc47d474aa9ca31b4a935bd8
@@ -4152,6 +4154,7 @@ SPEC CHECKSUMS:
   react-native-passkey: 3aac247c18127443ef4a002b59d8e12dc7e99f2e
   react-native-performance: 4194ce7222056671d8f0ce10e96a8fead7278550
   react-native-quick-base64: 651d972291fd5d9902869636a1b3c46820324490
+  react-native-quick-crypto: 71b622aa0a231ac068759f5eef37982ad5eae58c
   react-native-restart: 0bc732f4461709022a742bb29bcccf6bbc5b4863
   react-native-safe-area-context: 7e926a200d4bc9c56562275743705c6b56176455
   react-native-skia: 5c086469906cf854e26126b5b88dcbb6c93eb90f
@@ -4229,6 +4232,6 @@ SPEC CHECKSUMS:
   Yoga: adb397651e1c00672c12e9495babca70777e411e
   ZXingObjC: 8898711ab495761b2dbbdec76d90164a6d7e14c5
 
-PODFILE CHECKSUM: a2419b0d699403a5728ebd8c44ade7e08b6edb43
+PODFILE CHECKSUM: 5c40fea57eb45cbbb8186acd410997f14944226c
 
 COCOAPODS: 1.16.2

yarn.lock

@@ -514,6 +514,7 @@ __metadata:
     "@avalabs/svm-module": 3.1.3
     "@avalabs/tsconfig-mobile": "workspace:*"
     "@avalabs/types": 3.1.0-alpha.71
+    "@avalabs/unified-asset-transfer": 0.0.0-project-fusion-pr-20260211175355
     "@avalabs/vm-module-types": 3.1.3
     "@babel/core": 7.28.0
     "@babel/plugin-proposal-nullish-coalescing-operator": 7.18.6
@@ -806,7 +807,7 @@ __metadata:
     webdriverio: 9.23.0
     xss: 1.0.15
     zeego: 3.0.6
-    zod: 3.23.8
+    zod: 4.1.12
     zustand: 5.0.6
   languageName: unknown
   linkType: soft
@@ -1088,6 +1089,22 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@avalabs/unified-asset-transfer@npm:0.0.0-project-fusion-pr-20260211175355":
+  version: 0.0.0-project-fusion-pr-20260211175355
+  resolution: "@avalabs/unified-asset-transfer@npm:0.0.0-project-fusion-pr-20260211175355"
+  dependencies:
+    "@lombard.finance/sdk": ^4.1.0
+    "@scure/base": ^1.0.1
+    coinselect: ^3.1.13
+    es-toolkit: ^1.42.0
+  peerDependencies:
+    "@solana/kit": ^5.0.0
+    viem: ^2.38.0
+    zod: ^4.1.0
+  checksum: cad64b61189a29c04010833c51d7242632d1872571bc21427dbde3fbf307bb250c3906535b368be771d1699e0551e1dbd8e2ef19e87e5782224450a340ba1857
+  languageName: node
+  linkType: hard
+
 "@avalabs/vm-module-types@npm:3.1.3":
   version: 3.1.3
   resolution: "@avalabs/vm-module-types@npm:3.1.3"
@@ -9628,6 +9645,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@lombard.finance/sdk-common@npm:3.4.0":
+  version: 3.4.0
+  resolution: "@lombard.finance/sdk-common@npm:3.4.0"
+  peerDependencies:
+    "@bitcoinerlab/secp256k1": ^1.2.0
+    bitcoinjs-lib: ^6.1.5
+  checksum: e0ea4685270ca69b16c04f8f41c330f977d76e18518d175d4d249300afd9eeb741f3bd258e4569195ff16b6d5aba953ae804e026d2c85a7bab6292f5031c4b60
+  languageName: node
+  linkType: hard
+
 "@lombard.finance/sdk-common@npm:^3.3.1":
   version: 3.3.1
   resolution: "@lombard.finance/sdk-common@npm:3.3.1"
@@ -9657,6 +9684,23 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@lombard.finance/sdk@npm:^4.1.0":
+  version: 4.3.0
+  resolution: "@lombard.finance/sdk@npm:4.3.0"
+  dependencies:
+    "@lombard.finance/sdk-common": 3.4.0
+    isows: ^1.0.7
+  peerDependencies:
+    "@bitcoinerlab/secp256k1": ^1.2.0
+    "@layerzerolabs/lz-v2-utilities": ^3.0.17
+    axios: ^1
+    bignumber.js: ^9
+    bitcoinjs-lib: ^6.1.5
+    viem: ^2.21.0
+  checksum: 407e7fdc70e6b4120f4b5074d11634dc27a3af73584d4cb9dd02820e820c2dfdd7d45fb3f476158b8984ebbf564b425ed0859fe31aa9d6fb43e3170c574da542
+  languageName: node
+  linkType: hard
+
 "@metamask/abi-utils@npm:^2.0.2, @metamask/abi-utils@npm:^2.0.4":
   version: 2.0.4
   resolution: "@metamask/abi-utils@npm:2.0.4"
@@ -12721,6 +12765,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@scure/base@npm:^1.0.1, @scure/base@npm:~1.2.5":
+  version: 1.2.6
+  resolution: "@scure/base@npm:1.2.6"
+  checksum: 1058cb26d5e4c1c46c9cc0ae0b67cc66d306733baf35d6ebdd8ddaba242b80c3807b726e3b48cb0411bb95ec10d37764969063ea62188f86ae9315df8ea6b325
+  languageName: node
+  linkType: hard
+
 "@scure/base@npm:^1.1.3, @scure/base@npm:~1.1.3, @scure/base@npm:~1.1.6":
   version: 1.1.7
   resolution: "@scure/base@npm:1.1.7"
@@ -12742,13 +12793,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@scure/base@npm:~1.2.5":
-  version: 1.2.6
-  resolution: "@scure/base@npm:1.2.6"
-  checksum: 1058cb26d5e4c1c46c9cc0ae0b67cc66d306733baf35d6ebdd8ddaba242b80c3807b726e3b48cb0411bb95ec10d37764969063ea62188f86ae9315df8ea6b325
-  languageName: node
-  linkType: hard
-
 "@scure/bip32@npm:1.3.1":
   version: 1.3.1
   resolution: "@scure/bip32@npm:1.3.1"
@@ -20302,7 +20346,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"coinselect@npm:3.1.13":
+"coinselect@npm:3.1.13, coinselect@npm:^3.1.13":
   version: 3.1.13
   resolution: "coinselect@npm:3.1.13"
   checksum: 47731f5dcb4bcf1ab0c906dff5e79ef4c6f9d64acd3d93cf8c3d47ef6c5a0f5530892c68fc840e398db3d5491ab2aa4143110cca056b642c383c066f7942b511
@@ -22972,6 +23016,18 @@ __metadata:
   languageName: node
   linkType: hard
 
+"es-toolkit@npm:^1.42.0":
+  version: 1.44.0
+  resolution: "es-toolkit@npm:1.44.0"
+  dependenciesMeta:
+    "@trivago/prettier-plugin-sort-imports@4.3.0":
+      unplugged: true
+    prettier-plugin-sort-re-exports@0.0.1:
+      unplugged: true
+  checksum: cd1d0f791aa2329450bd27f090e3dd933558fd1888ad17e911db3ddadbee7020d2727d2d5f819502b3b015535e46d74554365f7e3b9f04c52180fff0be3f2cdd
+  languageName: node
+  linkType: hard
+
 "es6-promise@npm:4.2.8":
   version: 4.2.8
   resolution: "es6-promise@npm:4.2.8"
@@ -34815,7 +34871,7 @@ react-native-webview@ava-labs/react-native-webview:
   peerDependencies:
     react: "*"
     react-native: "*"
-  checksum: e08d1254d04f3074970b63cdf0a363d6b189009270d457e868a26ef534addd69b320b85bef2a22e4eddb79006751bded431b56aaf2baf41976a6d0a5a2a2b91e
+  checksum: d6ceb75e1d0f5755370d6d91f67902bd2b8a23a3ca43cb853d2964b43798f30477e8ab0223ea8b620534fbdf5f56d39550f40d24bec2d2398c323ccfe8a5a556
   languageName: node
   linkType: hard
 
@@ -41598,6 +41654,13 @@ react-native-webview@ava-labs/react-native-webview:
   languageName: node
   linkType: hard
 
+"zod@npm:4.1.12":
+  version: 4.1.12
+  resolution: "zod@npm:4.1.12"
+  checksum: 91174acc7d2ca5572ad522643474ddd60640cf6877b5d76e5d583eb25e3c4072c6f5eb92ab94f231ec5ce61c6acdfc3e0166de45fb1005b1ea54986b026b765f
+  languageName: node
+  linkType: hard
+
 "zod@npm:^3.21.4":
   version: 3.24.1
   resolution: "zod@npm:3.24.1"