fix: dereference on error

alarso16 · alarso16 · commit 7c56b589ea52 · 2025-11-10T16:38:50.000-05:00
diff --git a/triedb/firewood/database.go b/triedb/firewood/database.go
@@ -310,6 +310,7 @@ func (db *Database) Commit(root common.Hash, report bool) error {
 	start := time.Now()
 	// Commit the proposal to the database.
 	if err := pCtx.Proposal.Commit(); err != nil {
+		db.dereference(pCtx) // no longer committable
 		return fmt.Errorf("firewood: error committing proposal %s: %w", root.Hex(), err)
 	}
 	ffiCommitCount.Inc(1)

Original file line number	Diff line number	Diff line change
`@@ -310,6 +310,7 @@ func (db *Database) Commit(root common.Hash, report bool) error {`
`310`	`310`	`start := time.Now()`
`311`	`311`	`// Commit the proposal to the database.`
`312`	`312`	`if err := pCtx.Proposal.Commit(); err != nil {`
	`313`	`+ db.dereference(pCtx) // no longer committable`
`313`	`314`	`return fmt.Errorf("firewood: error committing proposal %s: %w", root.Hex(), err)`
`314`	`315`	`}`
`315`	`316`	`ffiCommitCount.Inc(1)`