Merge remote-tracking branch 'origin/main' into rkuris/simple-range-proof-verification

Author: rkuris

.config/nextest.toml

@@ -0,0 +1,9 @@
+[profile.default]
+# Skip tests prefixed with test_slow in default profile
+default-filter = "not test(test_slow)"
+
+[profile.ci]
+# Do not cancel the test run on the first failure.
+fail-fast = false
+# Override default filter to run all tests including slow ones
+default-filter = "all()"

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,23 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Possible Solutions**
+If known, give some ideas of what may be done to fix the problem.
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: enhancement
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/pull_request_template.md

@@ -0,0 +1,5 @@
+## Why this should be merged
+
+## How this works
+
+## How this was tested

.github/workflows/ci.yaml

@@ -151,17 +151,18 @@ jobs:
           - profile-key: debug-ethhash-logger
             profile-args: "--features ethhash,logger"
           - profile-key: maxperf-ethhash-logger
-            profile-args: "--profile maxperf --features ethhash,logger"
+            profile-args: "--cargo-profile maxperf --features ethhash,logger"
     runs-on: ${{ matrix.os || 'ubuntu-latest' }}
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
+      - uses: taiki-e/install-action@nextest
       - uses: Swatinem/rust-cache@v2
         with:
           save-if: "false"
           shared-key: ${{ matrix.profile-key }}
-      - name: Run tests with features enabled
-        run: cargo test --locked --verbose ${{ matrix.profile-args }}
+      - name: Run tests with cargo-nextest
+        run: cargo nextest run --locked --profile ci --verbose ${{ matrix.profile-args }}
 
   examples:
     needs: build
@@ -210,6 +211,7 @@ jobs:
             **/*.md
             !CHANGELOG.md
             !target/**
+            !.github/**
       - name: doc generation
         run: RUSTDOCFLAGS="-D warnings" cargo doc --locked --document-private-items --no-deps
 

.github/workflows/publish.yaml

@@ -20,11 +20,12 @@ jobs:
         run: |
           cargo login ${{ secrets.CARGO_TOKEN }}
           cargo publish -p firewood-macros
-      - name: publish firewood-triehash crate
-        continue-on-error: false
-        run: |
-          cargo login ${{ secrets.CARGO_TOKEN }}
-          cargo publish -p firewood-triehash
+      # TODO(demosdemon): detect when version is bumped and only publish then
+      # - name: publish firewood-triehash crate
+      #   continue-on-error: false
+      #   run: |
+      #     cargo login ${{ secrets.CARGO_TOKEN }}
+      #     cargo publish -p firewood-triehash
       - name: publish firewood-storage crate
         continue-on-error: false
         run: |

AGENTS.md

@@ -112,13 +112,23 @@ Before submitting/updating a PR, run the following
 
 ```bash
 cargo fmt                                                               # Format code
-cargo test --workspace --features ethhash,logger --all-targets          # Run tests
+cargo nextest run --workspace --features ethhash,logger --all-targets   # Run tests
 cargo clippy --workspace --features ethhash,logger --all-targets        # Linter
 cargo doc --no-deps                                                     # Ensure docs build
 ```
 
 All tests must pass, and there should be no clippy warnings.
 
+### Slow Tests
+
+If your PR modifies code that is tested by any test prefixed with `test_slow_`, you should also run the full test suite with the `ci` profile to ensure those tests pass:
+
+```bash
+cargo nextest run --workspace --features ethhash,logger --all-targets --profile ci
+```
+
+The `ci` profile includes slow tests that are skipped in the default profile for faster local development.
+
 ### Markdown Linter
 
 If your PR touches any Markdown file, run the following:
@@ -170,7 +180,7 @@ Key dependencies are centrally managed in workspace `Cargo.toml`:
    blocks without documentation and strong justification. Unsafe code could be
    utilized in the `ffi` crate.
 
-2. **Testing**: Any changes should include appropriate tests. Run `cargo test --release` to verify.
+2. **Testing**: Any changes should include appropriate tests. Run `cargo nextest run --release` to verify.
 
 3. **Performance Context**: This is a database designed for blockchain state. Performance matters. Consider allocation patterns and hot paths.
 

CHANGELOG.md

@@ -2,6 +2,101 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.0.18] - 2025-12-17
+
+### 🐛 Bug Fixes
+
+- Hash mismatch when proposing on uncommitted proposal ([#1557](https://github.com/ava-labs/firewood/pull/1557))
+
+### 🧪 Testing
+
+- Guarantee that revisions work after commit ([#1558](https://github.com/ava-labs/firewood/pull/1558))
+
+## [0.0.17] - 2025-12-16
+
+### 🚀 Features
+
+- *(ffi)* Stub for code hashes in proof ([#1526](https://github.com/ava-labs/firewood/pull/1526))
+- Add ffi support for dump() ([#1527](https://github.com/ava-labs/firewood/pull/1527))
+- Disable automatic io-uring enablement ([#1528](https://github.com/ava-labs/firewood/pull/1528))
+- [**breaking**] Open database with directory instead of filepath ([#1532](https://github.com/ava-labs/firewood/pull/1532))
+
+### 🐛 Bug Fixes
+
+- *(io-uring)* Use sqwait to correctly synchronize kernel updates ([#1523](https://github.com/ava-labs/firewood/pull/1523))
+- *(rootstore)* Respect db truncation ([#1538](https://github.com/ava-labs/firewood/pull/1538))
+- *(ffi/iterator)* Keep view alive for iterator lifetime ([#1542](https://github.com/ava-labs/firewood/pull/1542))
+- Generated instance names have whitespace ([#1550](https://github.com/ava-labs/firewood/pull/1550))
+
+### 🚜 Refactor
+
+- [**breaking**] Remove branch_factor_256 ([#1533](https://github.com/ava-labs/firewood/pull/1533))
+- [**breaking**] Go DB config to functional options pattern ([#1534](https://github.com/ava-labs/firewood/pull/1534))
+- *(ffi/iterator)* Move tests into a separate file ([#1543](https://github.com/ava-labs/firewood/pull/1543))
+
+### 🧪 Testing
+
+- *(fwdctl)* Parallelize test suite ([#1540](https://github.com/ava-labs/firewood/pull/1540))
+- *(firewood)* Reduce thread spawn count ([#1547](https://github.com/ava-labs/firewood/pull/1547))
+
+### ⚙️ Miscellaneous Tasks
+
+- Update GitHub templates ([#1525](https://github.com/ava-labs/firewood/pull/1525))
+- *(benchmark/bootstrap)* Remove Coreth branch option ([#1530](https://github.com/ava-labs/firewood/pull/1530))
+- *(firewood)* Clean up RevisionManager fields ([#1536](https://github.com/ava-labs/firewood/pull/1536))
+- Remove reference to RELEASES.md ([#1544](https://github.com/ava-labs/firewood/pull/1544))
+- Switch to cargo-nextest ([#1541](https://github.com/ava-labs/firewood/pull/1541))
+- Aws-launch.sh: libevm-commit -> libevm-branch ([#1552](https://github.com/ava-labs/firewood/pull/1552))
+- *(nextest)* Skip slow tests in local development ([#1551](https://github.com/ava-labs/firewood/pull/1551))
+
+## [0.0.16] - 2025-12-09
+
+### 🚀 Features
+
+- Use `parking_lot` to eliminate lock poisoning ([#1476](https://github.com/ava-labs/firewood/pull/1476))
+- *(ffi)* Protect unsafe concurrent ops ([#1474](https://github.com/ava-labs/firewood/pull/1474))
+
+### 🐛 Bug Fixes
+
+- Mark node as allocated before serializing parent ([#1489](https://github.com/ava-labs/firewood/pull/1489))
+- *(parallel)* Track deleted nodes from root branch in parallel propose ([#1491](https://github.com/ava-labs/firewood/pull/1491))
+- Refactor io-uring to drive the queue to completion ([#1498](https://github.com/ava-labs/firewood/pull/1498))
+- *(ffi)* Hold onto verification context in next key range ([#1486](https://github.com/ava-labs/firewood/pull/1486))
+- *(range-proof)* Skip leaf nodes that come before lower bound ([#1512](https://github.com/ava-labs/firewood/pull/1512))
+- Correct architecture for m5ad.2xlarge ([#1514](https://github.com/ava-labs/firewood/pull/1514))
+- Race condition between view and commit ([#1519](https://github.com/ava-labs/firewood/pull/1519))
+- *(range-proofs)* Generate proofs for lower and upper bounds correctly ([#1513](https://github.com/ava-labs/firewood/pull/1513))
+
+### 🚜 Refactor
+
+- *(rootstore)* Remove `MockStore` ([#1477](https://github.com/ava-labs/firewood/pull/1477))
+- *(firewood/db)* Unify reopen methods ([#1481](https://github.com/ava-labs/firewood/pull/1481))
+- *(db/revisionmanager)* Move `RootStore` creation to `RevisionManager` ([#1482](https://github.com/ava-labs/firewood/pull/1482))
+- *(rootstore)* Remove box pointer ([#1484](https://github.com/ava-labs/firewood/pull/1484))
+- *(rootstore)* Own nodestore logic ([#1495](https://github.com/ava-labs/firewood/pull/1495))
+- *(checker)* Separate check and fix ([#1506](https://github.com/ava-labs/firewood/pull/1506))
+
+### 📚 Documentation
+
+- *(ffi)* Update godoc ([#1466](https://github.com/ava-labs/firewood/pull/1466))
+
+### ⚡ Performance
+
+- Avoid extra copying when comparing `HashOrRlp` ([#1505](https://github.com/ava-labs/firewood/pull/1505))
+
+### 🧪 Testing
+
+- Optimize init_merkle by removing redundant verification passes ([#1504](https://github.com/ava-labs/firewood/pull/1504))
+- Enhance aws-launch with show and terminate options ([#1517](https://github.com/ava-labs/firewood/pull/1517))
+
+### ⚙️ Miscellaneous Tasks
+
+- Update golangci yaml files ([#1492](https://github.com/ava-labs/firewood/pull/1492))
+- Remove windows remnants ([#1503](https://github.com/ava-labs/firewood/pull/1503))
+- *(db)* Remove unused `all_hashes()` method ([#1509](https://github.com/ava-labs/firewood/pull/1509))
+- *(bootstrap)* Update SSH authorized key for user 'brandon' ([#1510](https://github.com/ava-labs/firewood/pull/1510))
+- [**breaking**] Reorganize proof code ([#1511](https://github.com/ava-labs/firewood/pull/1511))
+
 ## [0.0.15] - 2025-11-18
 
 ### 🚀 Features

CONTRIBUTING.md

@@ -23,7 +23,7 @@ guidelines for contributing to firewood.
 After submitting a PR, we'll run all the tests and verify your code meets our submission guidelines. To ensure it's more likely to pass these checks, you should run the following commands locally:
 
     cargo fmt
-    cargo test
+    cargo nextest run
     cargo clippy
     cargo doc --no-deps