fix: view and pure functions revert when paid

Author: ARR4N

libevm/precompilegen/precompile.go.tmpl

@@ -71,12 +71,11 @@ func (p precompile) run(env vm.PrecompileEnvironment, input []byte) ([]byte, err
         return p.impl.Fallback(env, input)
     }
 
+    payable := false
 	switch m := methods[selector]; m.StateMutability {
-	case "nonpayable":
-		if !env.Value().IsZero() {
-			return []byte(revertBufferWhenNonPayableReceivesValue), vm.ErrExecutionReverted
-		}
 	case "payable":
+        payable = true
+    case "nonpayable":
 	case "pure":
 		env = env.AsPure()
 	case "view":
@@ -87,6 +86,9 @@ func (p precompile) run(env vm.PrecompileEnvironment, input []byte) ([]byte, err
         data := fmt.Sprintf("unsupported state mutability %q on method %s", m.StateMutability, m.Sig)
 		return []byte(data), vm.ErrExecutionReverted
 	}
+    if !payable && !env.Value().IsZero() {
+        return []byte(revertBufferWhenNonPayableReceivesValue), vm.ErrExecutionReverted
+    }
 
     ret, err := dispatchers[selector](p.impl, env, input)
     switch err := err.(type) {

libevm/precompilegen/testprecompile/TestSuite.sol

@@ -93,18 +93,23 @@ contract TestSuite {
         uint256 value = precompile.Payable{value: 42}();
         assert(value == 42);
 
-        callNonPayable(0, "");
-        callNonPayable(1, abi.encodePacked(_expectedNonPayableErrorMsg));
+        bytes4 nonPayable = IPrecompile.NonPayable.selector;
+        callNonPayable(nonPayable, 0, "");
+
+        bytes memory err = abi.encodePacked(_expectedNonPayableErrorMsg);
+        callNonPayable(nonPayable, 1, err);
+        callNonPayable(IPrecompile.View.selector, 1, err);
+        callNonPayable(IPrecompile.Pure.selector, 1, err);
 
         emit Called("Transfer()");
     }
 
-    function callNonPayable(uint256 value, bytes memory expectRevertWith) internal {
+    function callNonPayable(bytes4 selector, uint256 value, bytes memory expectRevertWith) internal {
         // We can't use just call `precompile.NonPayable()` directly because
         // (a) it's a precompile and (b) it doesn't return values, which means
         // that Solidity will perform an EXTCODESIZE check first and revert.
-        bytes memory selector = abi.encodeWithSelector(IPrecompile.NonPayable.selector);
-        (bool ok, bytes memory ret) = address(precompile).call{value: value}(selector);
+        bytes memory data = abi.encodeWithSelector(selector);
+        (bool ok, bytes memory ret) = address(precompile).call{value: value}(data);
 
         if (expectRevertWith.length == 0) {
             assert(ok);