Check env.UseGas return value

qdm12 · qdm12 · commit 45ee2988051b · 2025-02-04T16:56:40.000+01:00
diff --git a/libevm/legacy/legacy.go b/libevm/legacy/legacy.go
@@ -44,7 +44,9 @@ func (c PrecompiledStatefulContract) Upgrade() vm.PrecompiledStatefulContract {
 			return nil, fmt.Errorf("%w: %d > %d", errRemainingGasExceedsSuppliedGas, remainingGas, gas)
 		}
 		if used := gas - remainingGas; used > 0 {
-			env.UseGas(used)
+			if hasEnoughGas := env.UseGas(used); !hasEnoughGas {
+				return nil, vm.ErrOutOfGas
+			}
 		}
 		return ret, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@ func (c PrecompiledStatefulContract) Upgrade() vm.PrecompiledStatefulContract {`
`44`	`44`	`return nil, fmt.Errorf("%w: %d > %d", errRemainingGasExceedsSuppliedGas, remainingGas, gas)`
`45`	`45`	`}`
`46`	`46`	`if used := gas - remainingGas; used > 0 {`
`47`		`- env.UseGas(used)`
	`47`	`+ if hasEnoughGas := env.UseGas(used); !hasEnoughGas {`
	`48`	`+ return nil, vm.ErrOutOfGas`
	`49`	`+ }`
`48`	`50`	`}`
`49`	`51`	`return ret, err`
`50`	`52`	`}`