Skip to content

Commit 7a78551

Browse files
committed
chore: nolint, error wrapping, and misc nits
1 parent 8bfe2b2 commit 7a78551

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

libevm/cmd/internalise/main.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func run(fileName string, args ...string) error {
7878
mode := parser.SkipObjectResolution | parser.ParseComments
7979
parsed, err := parser.ParseFile(fset, fileName, nil, mode)
8080
if err != nil {
81-
return err
81+
return fmt.Errorf("parser.ParseFile(%q): %v", fileName, err)
8282
}
8383

8484
for _, d := range parsed.Decls {
@@ -92,7 +92,7 @@ func run(fileName string, args ...string) error {
9292
case *ast.Ident:
9393
typ = t.Name
9494
case *ast.StarExpr:
95-
typ = t.X.(*ast.Ident).Name
95+
typ = t.X.(*ast.Ident).Name //nolint:forcetypeassert // Invariant of valid Go method
9696
}
9797

9898
name := &fn.Name.Name
@@ -105,12 +105,13 @@ func run(fileName string, args ...string) error {
105105
}
106106
}
107107

108-
f, err := os.OpenFile(fileName, os.O_TRUNC|os.O_WRONLY, 0)
108+
// Since we're not creating, the zero perm/mode is ignored.
109+
f, err := os.OpenFile(fileName, os.O_TRUNC|os.O_WRONLY, 0) //nolint:gosec // Variable file is under our direct control in go:generate
109110
if err != nil {
110-
return err
111+
return fmt.Errorf("os.OpenFile(%q, [write-only, truncate]): %v", fileName, err)
111112
}
112113
if err := format.Node(f, fset, parsed); err != nil {
113-
return err
114+
return fmt.Errorf("format.Node(%T): %v", parsed, err)
114115
}
115116
return f.Close()
116117
}

0 commit comments

Comments
 (0)