fix linter

Author: ceyonur

common/hexutil/hexutil.libevm.go

@@ -33,7 +33,7 @@ func DecodeUint16(input string) (uint16, error) {
 			return 0, ErrUint16Range
 		}
 	}
-	return uint16(dec), err
+	return uint16(dec), err //nolint:gosec // G115 won't overflow uint16 as ParseUint uses 16 bits
 }
 
 // EncodeUint16 encodes i as a hex string with 0x prefix.

common/hexutil/hexutil.libevm_test.go

@@ -47,7 +47,11 @@ var (
 
 func TestEncodeUint16(t *testing.T) {
 	for _, test := range encodeUint16Tests {
-		enc := EncodeUint16(test.input.(uint16))
+		input, ok := test.input.(uint16)
+		if !ok {
+			t.Errorf("input %v: not a uint16", test.input)
+		}
+		enc := EncodeUint16(input)
 		if enc != test.want {
 			t.Errorf("input %x: wrong encoding %s", test.input, enc)
 		}
@@ -60,8 +64,12 @@ func TestDecodeUint16(t *testing.T) {
 		if !checkError(t, test.input, err, test.wantErr) {
 			continue
 		}
-		if dec != test.want.(uint16) {
-			t.Errorf("input %s: value mismatch: got %x, want %x", test.input, dec, test.want)
+		want, ok := test.want.(uint16)
+		if !ok {
+			t.Errorf("want %v: not a uint16", test.want)
+		}
+		if dec != want {
+			t.Errorf("input %s: value mismatch: got %x, want %x", test.input, dec, want)
 			continue
 		}
 	}

common/hexutil/json.libevm.go

@@ -17,7 +17,6 @@
 package hexutil
 
 import (
-	"fmt"
 	"reflect"
 	"strconv"
 )
@@ -60,7 +59,7 @@ func (b *Uint16) UnmarshalText(input []byte) error {
 			return ErrSyntax
 		}
 		dec *= 16
-		dec += uint16(nib)
+		dec += uint16(nib) //nolint:gosec // G115 won't overflow uint16 as decodeNibble uses 4 bits
 	}
 
 	*b = Uint16(dec)
@@ -71,20 +70,3 @@ func (b *Uint16) UnmarshalText(input []byte) error {
 func (b Uint16) String() string {
 	return EncodeUint16(uint16(b))
 }
-
-// ImplementsGraphQLType returns true if Uint16 implements the provided GraphQL type.
-func (b Uint16) ImplementsGraphQLType(name string) bool { return name == "Int" }
-
-// UnmarshalGraphQL unmarshals the provided GraphQL query data.
-func (b *Uint16) UnmarshalGraphQL(input interface{}) error {
-	var err error
-	switch input := input.(type) {
-	case string:
-		return b.UnmarshalText([]byte(input))
-	case int32:
-		*b = Uint16(input)
-	default:
-		err = fmt.Errorf("unexpected type %T for Int", input)
-	}
-	return err
-}

common/hexutil/json.libevm_test.go

@@ -51,8 +51,12 @@ func TestUnmarshalUint16(t *testing.T) {
 		if !checkError(t, test.input, err, test.wantErr) {
 			continue
 		}
-		if uint16(v) != test.want.(uint16) {
-			t.Errorf("input %s: value mismatch: got %d, want %d", test.input, v, test.want)
+		want, ok := test.want.(uint16)
+		if !ok {
+			t.Errorf("want %v: not a uint16", test.want)
+		}
+		if uint16(v) != want {
+			t.Errorf("input %s: value mismatch: got %d, want %d", test.input, v, want)
 			continue
 		}
 	}
@@ -62,7 +66,10 @@ func BenchmarkUnmarshalUint16(b *testing.B) {
 	input := []byte(`"0x1234"`)
 	for i := 0; i < b.N; i++ {
 		var v Uint16
-		v.UnmarshalJSON(input)
+		err := v.UnmarshalJSON(input)
+		if err != nil {
+			b.Errorf("error unmarshalling: %v", err)
+		}
 	}
 }